I have only skimmed the code briefly, but what exactly is not working?

The randomeness? Tri and Squares not actually appearing? Did you seed (with srand() ) the random function?

If I understand you correctly, you want to generate something like
.........x.....xo.....oxxo......
but your code only generates something like
...x...o...o...x...x...o......x
sometimes with a triangle and a square sharing the same coordinate?

First off: They are ovelapping, because you're checking if a square or triangle should be generated individually instead of checking if an obstacle is to be generated in general and then deciding, whether the obstacle should be a square or a triange. In other words: If the first rand()%200 generates a zero, you create a triangle, but the second rand()%200 can generate a 1 right after the zero, in which case you create a new square at the same coordinates as the riangle.
If you want to avoid overlapping, rewrite your code to

if(rand()%200 == 0) //create obstacle
{
   if(rand()%2 == 0) //obstacle is a triangle
   {
      //put triangle creainon code here
   }
   else //obstacle is a square
   {
      //put square creainon code here
   }
}

If you want your code to genarate a random group of obstacles like
..xooxoxxoxxxo..
you could use do something like this:

This code would generate a line from 2 to 17 obstacles off screen.
Take note that the code also eventually will generate overlapping object in the line, as it doesn't check if there already is an object at 800 + Cameraposition[0]
Never mind, apparently you're checking for overlaps already, though I don't understand what your logic is behind that. What exactly are the square and triangle object and how and where are they defined?

When you add an obstacle (or series), you should compute the width of what you've created. Don't create anything more until the screen has scrolled by this width + the minimum distance you want between two series.

LUPUSS caught my problem. And KILLOCAN what you said is perfectly what i want to do.

I am going back on computer to bang my head against code wall. Lets see if i make it to the other side of problem. But KILLOCAN how do i make those combinations , because to render my gameobjects i used a list. So what you suggested is all blurry. But I will give it many tries too.

UPDATED:------------------------------------------------------------

Guys look I tried this thing to get the combination of obstacles like KILLOCAN said, using what Lupuss suggested.

Now also i am facing a problem.:-[

I think there is some conflict between creation of triangles and that of squares. No triangle overlaps other triangle. No Square overlaps other square. But either triangle overlap a square which is already drawn, OR a square overlaps an already drawn triangle. Can you see any error in my triangle/square creation code?

When they overlap, somehow both get drawn on same place such that their x & y coordinates (or Their centre points) are same.

I think you should getrid of

 if(!(triangle->GetX() - 15 < t->GetX() + 15 && triangle->GetX() + 15 > t->GetX() - 15) && !(square->GetX() - 40 < t->GetX() + 15 && square->GetX() + 40 > t->GetX() - 15) ) continue;

altoether and do what Audric said

P.S.:

Sorry, but I recognize neither his, nor my approach...

You need to implement code for each combination of obstacle you want to do.

Or make an array of rand()%3 (empty / triangle / square) to determine what is coming up next and then add those objects to your game.

Actually I would go with the second method. Use an array / list / vector to store a sequence of randomly generated objects with possible empty spaces between them. The first method means largely writing more code than you should, since its easier to work on a whole array instead of all the specific use cases.

The 'Give Credits' option is only available if you make the new thread classification 'a question with a specific answer'.

What i suggest can be expressed(in pseudo correct code hehehe) as something like this:

You can make it an std::vector(if you like) (instead of array) and load it with random shapes during the stage setup, then use it like i did.