Problem destroying bitmaps objects a destructor

Problem destroying bitmaps objects a destructor

chex_5

Member #14,081

February 2012

Hello, could anyone shed some light on why I have this problem destroying bitmaps & text? When I place al_destroy_bitmap() or al_destroy_font() in a class destructor, my program crashes when I try to close it. I made a workaround where I created an "unload()" function before I actually destroy the object, but that seems a little excessive.

The objects are created using the following code

#SelectExpand
  1class text {
  2        private:
  3                ALLEGRO_FONT* font;
  4        public:
  5                text(const char* fontFile, int size, flags=0)     {font = al_create_font(fontFile, size, flags);}
  6                ~text();                                          {//left blank or else the program will crash}
  7}
  8
  9class sprite{
 10        private:
 11                ALLEGRO_BITMAP* image;
 12        public:
 13                sprite(const char* bitmapFile)                    {image = al_load_bitmap(bitmapFile);}
 14                ~sprite();                                        {//left blank or else the program will crash}
 15}

These destructors cause the program to crash unless they're left blank

#SelectExpand
 1text::~text() {
 2  al_destroy_font(font);
 3}
 4
 5sprite::~sprite() {
 6  al_destroy_bitmap(image);
 7}

And these are the unload functions that I have to call before destroying the object

#SelectExpand
 1text::unload() {
 2        al_destroy_font(font);
 3}
 4
 5sprite::unload() {
 6        al_destroy_bitmap(image);
 7}

What also seems weird is that I cannot place the unload functions in the destructors either. Can anyone help me out?

Edgar Reynaldo

Major Reynaldo

May 2007

Uhm, no. Both of those do exactly the same things.

Potential cause 1 : You are making copies of your text or sprite objects. This only performs a shallow copy of the pointer holding the resource, and when they go out of scope they get destroyed. Then when the original goes out of scope, it tries to destroy the same resource a second time, which would crash.

Potential cause 2 : You haven't properly initialized the necessary addons, for the fonts or for the images, which means your load calls will return null, and then when they go out of scope they try to destroy a null pointer, which will crash.

Potential cause 3 : They just aren't loading properly, but you don't check so you wouldn't know.

So, first make sure your resources are loading properly, either through text output, or through exceptions, or whatever else makes you happy.

Second, make sure the addons are initialized.

Third, make sure you don't make copies by value of your text and sprite objects, or write a proper copy constructor.

Eagle and Allegro 5 binaries | Older Allegro 4 and 5 binaries | Allegro 5 compile guide
King Piccolo will make it so Then I could just flip it with some sweet, sweet matrix math. In either case, I’ll ride this wagon until the wheels fall off. Thanks to those that keep it running

chex_5

Member #14,081

February 2012

The code I posted was just pseudocode. I have all of the addons initialized, the fonts and bitmaps using each class load properly, but where I run into problems is when I place "al_destroy_font()" or "al_destroy_bitmap()" in the destructor. I also run into problems if I place the unload functions in the corresponding class destructor as well.
Otherwise, the code runs fine when each unload/al_destroy function is called independent of the destructor, but crashes if placed inside of it. I'll go ahead and post the actual code that I have:

#SelectExpand
  1#ifndef TEXT_H
  2#define  TEXT_H
  3
  4class text {
  5private:
  6  ALLEGRO_FONT* font;
  7  ALLEGRO_COLOR color;
  8  ALLEGRO_USTR_INFO textInfo;
  9  ALLEGRO_USTR* ustring;
 10  int size;
 11  float x;
 12  float y;
 13  
 14public:
 15  text();
 16  ~text();
 17  
 18  void  loadFont    (const char* file, int fontSize, int allegroFlags = 0);
 19  void  unloadFont    ();              //MUST be called before the destructor!
 20  float  getPosX      () const          {return x;}
 21  float  getPosY      () const          {return y;}
 22  int    getSize      () const          {return size;}
 23  ALLEGRO_COLOR getColor  () const          {return color;}
 24  void  setPos      (float xPos, float yPos)  {x = xPos; y = yPos;}
 25  void  setText      (const char* textData);
 26  void  setColor    (float r, float g, float b, float a);
 27  void  draw      (int allegroFlags = 0);
 28};
 29
 30inline void text::draw(int allegroFlags) {
 31  al_draw_ustr(  font, color, x, y, allegroFlags, ustring);
 32}
 33
 34inline void text::setText(const char* textData) {
 35  al_ustr_free(ustring);
 36  ustring = al_ref_cstr(&textInfo, textData);
 37}
 38
 39#endif  /* TEXT_H */

#SelectExpand
  1#include "text.h"
  2//addons have already been initialized in another file
  3
  4text::text() {
font = NULL;
ustring = NULL;
size = 0;
x = 0;
y = 0;
color.r = 0.0f;
color.g = 0.0f;
color.b = 0.0f;
color.a = 0.0f;
 14}
 15
 16text::~text() {
//al_destroy_font(font);
al_ustr_free(ustring);
 19}
 20
 21void text::loadFont(const char* file, int fontSize, int allegroFlags) {
unloadFont();
size = fontSize;

//search for true-type fonts by looking at the last two characters of the file extension
std::string fileParser = file;
unsigned int sizeCounter = fileParser.size();
//there should be support for *.ttf & *.otf-style fonts
if (  (fileParser[sizeCounter - 1] == 'f' && fileParser[sizeCounter - 2] == 't')
    || (fileParser[sizeCounter - 1] == 'F' && fileParser[sizeCounter - 2] == 'T')) {
  fileParser = "TTF";
  font = al_load_ttf_font(file, size, allegroFlags);
}
else {
  fileParser = "Bitmap";
  font = al_load_font(file, size, allegroFlags);
}

if (font != NULL) {
  LOG("Successfully loaded font:\n");
  LOG("\tFile:\t%s\n", file);
}
else {
  LOG("WARNING: Could not load font:\n");
  LOG("\tFile:\t%s\n", file);
}

LOG("\tType:\t%s\n", fileParser.c_str());
 49}
 50
 51void text::setColor(float r, float g, float b, float a) {
  color.r = r;
  color.g = g;
  color.b = b;
  color.a = a;
 56}
 57
 58void text::unloadFont() {
al_destroy_font(font);
al_ustr_free(ustring);
size = 0;
x = 0;
y = 0;
color.r = 0.0f;
color.g = 0.0f;
color.b = 0.0f;
color.a = 0.0f;
 68}

Edgar Reynaldo

Major Reynaldo

May 2007

Well, if they're loading properly, and your 'unload' function works properly when you call it yourself, then you are probably destroying the same resource multiple times due to shallow copying.

Make your destructor log each destruction :

text::~text() {
  LOG("Destroying font %p..." , font);
  al_destroy_font(font);
  LOG("Destroying ustring %p..." , ustring);
  al_ustr_free(ustring);
}

See if the same address gets destroyed twice...

Or, just make a test copy constructor :

   text(const text& t) {LOG("text object shallow copied");}

chex_5

Member #14,081

February 2012

Thanks for the reply.
I tried adding a blank copy constructor and logged it, as well as the regular constructor and destructor, but it doesn't seem as though any extra copies are being created. I think I'm going to download the allegro source code to see what might be causing this issue behind the scenes.

Edgar Reynaldo

Major Reynaldo

May 2007

This is not a problem with Allegro, I can tell you that right now. If you call al_destroy_font in one function, that is the same thing as calling it in another function.

Fire up a debugger first, and get a backtrace of the stack when it crashes. That will be WAY easier than trying to find a bug in Allegro that isn't there....