Problem creating a bitmap, and a class

Problem creating a bitmap, and a class

Paul Hoey

Member #7,189

May 2006

DATAFILE *data = NULL;
!**!BITMAP *bg = NULL;
    
//a function to initalise some resources
void init_data()
{
    data = load_datafile("bboy.dat");
    bg = (BITMAP*)data[bg].dat; 
}

The line with the !**! in front of it gives the following error:
expected unqualified-id before numeric constant
expected init-declarator before numeric constant
expected `,' or `;' before numeric constant

Same with this code:

1//the ball class
2class ball
3{
4      public:
5             int ballX;
6             int ballY;
7             BITMAP *ballImage;
8      public:
9             void init(int x, int y);
10             void drawBall(BITMAP *method_buffer);
11};
12 
13void ball::init(int x, int y)
14{
15     ballX = x;
16     ballY = y;
17     ballImage = (BITMAP*)data[ball].dat;
18};

Any ideas on the problem?

Jonatan Hedborg

Member #4,886

July 2004

Post the whole file. Probably some syntactical error earlier.

X-G

Member #856

December 2000

ballImage = (BITMAP*)data[ball].dat;

... and you also have a class named "ball". Name conflict.

--
Since 2008-Jun-18, democracy in Sweden is dead. | 悪霊退散！悪霊退散！怨霊、物の怪、困った時は　ドーマン！セーマン！ドーマン！セーマン！　直ぐに呼びましょう陰陽師レッツゴー！

Paul Hoey

Member #7,189

May 2006

Why would there be a conflict if I'm loading it form a data file, though?

Here's the whole file:

1//this is to use allegro
2#include <allegro.h>
3#include ".\bboy_head.h"
4 
5volatile long speed_counter = 0; // A long integer which will store the value of the
                               // speed counter.
7 
8void increment_speed_counter() // A function to increment the speed counter
9{
speed_counter++; // This will just increment the speed counter by one. :)
11}
12END_OF_FUNCTION(increment_speed_counter); // Make sure you tell it that it's the end of the
                                        // function
14DATAFILE *data = NULL;
15//BITMAP *bg = NULL; 
16 
17//a function to initalise some resources
18void init_data()
19{
  data = load_datafile("bboy.dat");
  //bg = (BITMAP*)data[bg].dat;
22};

24//the player class
25class player
26{
  //to store the image and the cooards
  public:
      int playerX;
      int playerY;
      int dir; //1 = right, 2 = left
      int state; //0 = idle, 1 = run, 2 = jump
      int constantY;
      int velocity;
      bool maxJump;
      BITMAP *player_image;
      BITMAP *player_idle_r;
      BITMAP *player_run_r;
      BITMAP *player_jump_r;
      
      BITMAP *player_idle_l;
      BITMAP *player_run_l;
      BITMAP *player_jump_l;
      
  //a few methods we'll be needing
  public:
      void move_left(); //moves the player left
      void move_right(); //moves the player right
      void draw_player(BITMAP *method_buffer); //just takes in a buffer that th epalyer is drawn to
      void init(int x, int y); //initilises the player values  
      //void throwBall(int x, int y, ball temp);
      void jump();
      //void throwBall(int x, int y, ball temp);
54};
55 
56void player::init(int x, int y)
57{
  playerX = x;
  playerY = y;
  constantY = playerY;
  velocity = 2;
  maxJump = false;
  player_idle_r = (BITMAP*)data[idle_r].dat;
  player_run_r = (BITMAP*)data[run_r].dat;
  player_jump_r = (BITMAP*)data[jump_r].dat;
  
  player_idle_l = (BITMAP*)data[idle_l].dat;
  player_run_l = (BITMAP*)data[run_l].dat;
  player_jump_l = (BITMAP*)data[jump_l].dat;
  
  dir = 1;
  state = 0;
  
  player_image = player_idle_r;
75};
76 
77void player::draw_player(BITMAP *method_buffer)
78{
   if(dir == 1)
   {
          //direction is right, so we'll be using the right images
          if(state == 0)
          {
                player_image = player_idle_r;
          } 
          else
          if(state == 1)
          {
                   player_image = player_run_r;
          }
          else
          {
              player_image = player_jump_r;
          }
   }
   else
   if(dir == 2)
   {
          //direction is left, so we'll be using the left images
          if(state == 0)
          {
                player_image = player_idle_l;
          } 
          else
          if(state == 1)
          {
                   player_image = player_run_l;
          }
          else
          {
              player_image = player_jump_l;
          }
   }
  draw_sprite(method_buffer, player_image, playerX, playerY);
115};
116 
117void player::move_left()
118{
  playerX--;
  dir = 2;
  state = 1;
122};
123 
124void player::move_right()
125{
  playerX++;
  dir = 1;
  state = 1;
129};
130 
131void player::jump()
132{
   state = 2;
   if(maxJump == false)
   {
      playerY--;
          
      if(playerY <= constantY - 40)
      {
          maxJump = true;
      }
  }
  else
  if(maxJump == true)
  {
      playerY++;
      
      if(playerY >= constantY)
      {
          maxJump = false;
      }
  }
  
154};
   
156/*
157void player::throwBall(int x, int y, ball temp)
158{
   
160};
161
162//the ball class
163class ball
164{
    public:
           int ballX;
           int ballY;
           BITMAP *ballImage;
    public:
           void init(int x, int y);
           void drawBall(BITMAP *method_buffer);
172};
173
174void ball::init(int x, int y)
175{
   ballX = x;
   ballY = y;
   ballImage = (BITMAP*)data[ball].dat;
179};
180*/
181//our main method
182int main(void)
183{
  //this initilises Allegro
  if(allegro_init() != 0)
  {
      return 1;
  }
  
  //set the colour depth
  set_color_depth(24);
  
  //here we set up a new window to use
  //the first parameter is the driver we're using
  //the next 2 specify height and width
  //the last 2 are for memory allocation
  if (set_gfx_mode(GFX_AUTODETECT, 800, 600, 0, 0) != 0)
  {
      //should te above fail, we want to try and set it using SAFE mode
      if(set_gfx_mode(GFX_SAFE, 800, 600, 0, 0) != 0)
      {
          //and if that fails we want to tell the suer why the program will not work
          set_gfx_mode(GFX_TEXT, 0, 0, 0, 0);
          allegro_message("Unable to initiate any graphics mode!\n$s\n", allegro_error);
          return 1;
      }
  }
     
  //clear the screen to be entirely white
  clear_to_color(screen, makecol(255, 255, 255));
      
  //this installs the keyboard driver so we can use it
  install_keyboard();
  
  //this installs the mouse
  install_mouse();
  
  //installing the timer routines
  install_timer();
  
  //creating a timer
  install_int_ex(increment_speed_counter, BPS_TO_TIMER(60));
  
  //declaring & creating the buffer
  BITMAP *buffer = create_bitmap(800, 600);
  
  //init our data
  init_data();
  
  player bboy;
  
  bboy.init(400, 200); 
  
  //the mosue cursor
  //BITMAP *cursor;
  
  //cursor = (BITMAP*)data[mouse_cursor].dat;
                 
  while(!key[KEY_ESC])
  {   
      if(key[KEY_A])
      {
          bboy.move_left();
      }
      else
      if(key[KEY_D])
      {
          bboy.move_right();
      }
      else
      {
          bboy.state = 0;
      }
254 
      if(key[KEY_SPACE])
      {
          bboy.jump();
      }
      else
      {
          bboy.velocity = 2;
      }
  
      //draw_sprite(buffer, bg, 0, 0); 
      bboy.draw_player(buffer);  
      
      textout_ex(buffer, font, "WASD to move", 10, 10, makecol(255, 255, 255), -1);  
  
      //drawing the mouse cursor to the screen
      //draw_sprite(buffer, cursor, mouse_x, mouse_y);        
      //drawing the buffers
      blit(buffer, screen, 0, 0, 0, 0, 800, 600);
      //clearing the buffer
      clear_bitmap(buffer);
  }
  
  //now we wait for a key press
  readkey();
  destroy_bitmap(buffer);
  //unload_datafile(falling);
  return 0;
282}
283 
284//we have to call this when using Allegro
285END_OF_MAIN()

CGamesPlay

Member #2,559

July 2002

When you name a datafile object like that, grabber makes a header file like this:

#define ball 1

That means that wherever the word "ball" appears in your source code, the compiler changes it to a "1". So, your code looks like this:

class 1
{
...

Well, obviously that isn't valid. That is why we typically name datafile objects in all capital letters, because we don't name variables and classes in all capital letters.

So, the answer is to change the name of the object in the datafile to something like "DATAFILE_BALL" instead of "ball".

[append]
The same goes for bg and, well, anything else in the data file.

--
Tomasu: Every time you read this: hugging!

Ryan Patterson - <http://cgamesplay.com/>

Paul Hoey

Member #7,189

May 2006

Ah, okay. Thank you.

Audric

Member #907

January 2001

You can automate half of the changes:

allegro manual said:

To prevent name conflicts, you can specify a prefix string for these definitions by typing it into the "Prefix:" field in the grabber or using the '-p' option to dat

ie: if you use a prefix like "datafile_item_", the generated header file will automatically be #define datafile_item_ball 1
You'll still have to change the "calls" yourself, anyway: ballImage = (BITMAP*)data[datafile_item_ball].dat;

Tobias Dammers

Member #2,604

August 2002

Quote:

So, the answer is to change the name of the object in the datafile to something like "DATAFILE_BALL" instead of "ball".

Another option (which I tend to use) is keeping the file extensions when adding objects to the datafile. The dat tool does this by default, so the following command:

dat mydatafile.dat -a foo.bmp -t BMP

...will add a bitmap object called "FOO_BMP" to the datafile (letters are automatically uppercased, and all non-alphanumeric characters are converted to underscores). Since your identifiers don't usually end with _BMP or _PCX or _WAV or whatever extension you use, this works rather well.

---
Me make music: Triofobie
---
"We need Tobias and his awesome trombone, too." - Johan Halmén

ImLeftFooted

Member #3,935

October 2003

Now try naming the new entry something besides foo.bmp

Ya, ya thats right, you can't do it!

How is my posting?