OpenLayer memory leak?

OpenLayer memory leak?

Richard Phipps

Member #1,632

November 2001

Maybe I'm missing something, but here is the upload_texture routine from OpenLayer:

1OlTextureInfo AllegroGLDriver::
2UploadTexture( OL_MEMORY_IMG *bmp, bool isSolid ) {
 isSolid = false;
 bool useTemp = false;
 
 int bmpW = bmp->w;
 int bmpH = bmp->h;
 
 int textureW = bmpW;
 int textureH = bmpH;
 
 bool useExtendedDimensions = false;
 
 if( !IsExtensionAlvailable( TEXTURE_NOT_POWER_OF_TWO_EXT )) {
    int bmpW = bmp->w;
    int bmpH = bmp->h;
    
    textureW = ToNextPowOfTwo( bmpW );
    textureH = ToNextPowOfTwo( bmpH );
    
    useExtendedDimensions = textureW != bmpW || textureH != bmpH;
 }
 
 int format = isSolid? GL_RGB : GL_RGBA;
 int bpp = isSolid? 3 : 4;
 /*
 unsigned char *data = new unsigned char[textureW * textureH * bpp];
 unsigned char *pixelPtr = data;
 */
 
 unsigned char *data = new unsigned char[textureW * textureH * bpp];
 //float *data = new float[textureW * textureH * bpp];
 
 char buffer[100];
 
 unsigned char *imageStart = data + bpp * (textureH - bmpH) * textureW;
 unsigned char *pixelPtr = imageStart;
 for( int y = bmpH-1; y >= 0; y-- ) {
    for( int x = 0; x < bmpW; x++ ) {
       int color = getpixel( bmp, x, y );
       ExtractColor( pixelPtr, color, format );
    }
    
    pixelPtr += bpp * (textureW - bmpW);
 }
 
 if( useExtendedDimensions ) {
    int lastLine = bmpH - 1;
    pixelPtr = imageStart - bpp * textureW;
    for( int x = 0; x < bmpW+1; x++ ) {
       int color = getpixel( bmp, x, lastLine );
       ExtractColor( pixelPtr, color, format );
    }
    
    for( int y = 0; y < bmpH; y++ ) {
       int color = getpixel( bmp, bmpW-1, y );
       pixelPtr = imageStart + bpp * (y * textureW + bmpW);
       ExtractColor( pixelPtr, color, format );
    }
 }
 
 OlTextureInfo textureInfo( textureW, textureH, bmp->w, bmp->h, format );
 
 GLuint index = 0;
 glGenTextures( 1, &index );
 glBindTexture( GL_TEXTURE_2D, index );
 
 glTexEnvf( GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE );
 
 glTexParameterf( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER,
                  GL_LINEAR_MIPMAP_NEAREST );
 
 glTexParameterf( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR );
 
 glTexImage2D( GL_TEXTURE_2D, 0, bpp, textureW, textureH, 0, format, GL_UNSIGNED_BYTE, data );
 
 /*glTexImage2D( GL_TEXTURE_2D, 0, 4, textureInfo.texWidth, textureInfo.texHeight,
               0, GL_RGBA, GL_UNSIGNED_BYTE, data );*/
 textureInfo.SetIndex( index );
 
 return textureInfo;
82}

Two things:

char buffer[100];

Is not used as far as I can see, but more importantly the malloced 'data' array is not freed at the end of the function. This data shouldn't still be needed in memory as this array is separate to the memory bitmap copy.

Unless I'm missing something?

Chaos Groove Development Blog
Free Logging System Code & Blog

orz

Member #565

August 2000

The buffer is on the stack, and therefore cannot be leaked (assuming the function returns sometime...).

The newed data array does appear to never be deleted. I believe that's a leak. At least, comparing it to other source code that calls glTexImage2D, like NeHe tutorial 06, I see that NeHe frees the memory it passes to glTexImage2D shortly after that call, whereas this code appears to let all pointers at the memory get lost.
edit: "points" -> "pointers" (typo)

Richard Phipps

Member #1,632

November 2001

Yep, buffer is on the stack, but it's not used so can be removed.

Yes, I imagine that the GlTexImage2D takes the data in the formats described and creates a version in video memory. So, the memory data passed can be freed.

Chaos Groove Development Blog
Free Logging System Code & Blog

Fladimir da Gorf

Member #1,565

October 2001

Thanks for noticing, I've got it fixed now

OpenLayer has reached a random SVN version number ;) | Online manual | Installation video!| MSVC projects now possible with cmake | Now alvailable as a Dev-C++ Devpack! (Thanks to Kotori)

Richard Phipps

Member #1,632

November 2001

Cool.

When can we see an official new release Fladimir? I think v2.0 is getting a bit old now.

Chaos Groove Development Blog
Free Logging System Code & Blog

Epsi

Member #5,731

April 2005

As soon as his Rectangular TextRenderer Poly is working 8-)

___________________________________

piccolo: "soon all new 2d alegro games will be better. after i finsh my MMRPG. my game will serve as a code reference. so you can understand and grab code from."
piccolo: "just wait until my invetion comes out its going to take the wii to the next leave of game play. it will run sony and microsoft out of busness if i dont let them use it aswell."

Richard Phipps

Member #1,632

November 2001

I'd like to see an new easy to compile version please.

Chaos Groove Development Blog
Free Logging System Code & Blog