strange problem with packfiles

strange problem with packfiles

waldermort

Member #6,259

October 2005

I have 2 simple functions, 1 for saving the other for loading:

1void save_data()
2{
PACKFILE *file;
file = pack_fopen("default.set","wp");
if (!file)
  return;
7 
for (int i=0;i<4;i++) {
  // write the name
  pack_fwrite(pData[0]<i>.name,15,file);    // english name
  pack_fwrite(pData[1]<i>.name,15,file);    // chinese name
  int win = atoi(pData[0]<i>.money);      
  pack_iputl(win,file);            // money coverted to int
  pack_iputl(pData[0]<i>.lev,file);      // level
  pack_iputl(pData[0]<i>.pic,file);      // picture
  pack_iputl(pData[0]<i>.scatterbrain,file);  // scatterbrain
}
pack_iputl(SBall.pos,file);            // speed position
pack_iputl(MBall.pos,file);            // music position
pack_iputl(FBall.pos,file);            // sound fx position
pack_iputl(language,file);            // selected language
pack_iputl(stake,file);              // selected stake
23 
pack_fclose(file);
25}
26 
27void load_data()
28{
char *pName[2][4] = {{"Micky Mouse","Pink Panther","Your Name?","John Doe"},
              {"¹¶Ð¡Ñà","Ä§Íõ","ÄúµÄÃû×Ö£¿","ÃùÈË"}};
char *pType[2][5] = {{"Idiot","Beginner","Average","Advanced","Professor"},
              {"±¿µ°","³õ¼¶","ÖÐ¼¶","¸ß¼¶","×¨¼Ò"}};

for (int i=0;i<2;i++)    // language
  for (int j=0;j<4;j++)    // player
    for (int k=0;k<5;k++)    // level
      pData<i>[j].level[k] = pType<i>[k];
38 
PACKFILE *file;
file = pack_fopen("default.set","rp");
if (!file) {
  for (int i=0;i<2;i++) {    // language
    for (int j=0;j<4;j++) {    // player
      pData<i>[j].lev = 2;
      pData<i>[j].name = pName<i>[j];
      pData<i>[j].money = "50000";
      pData<i>[j].pic = 0;
      pData<i>[j].scatterbrain = true;
    }
  }
  SBall.pos  = 50;
  MBall.pos  = 127;
  FBall.pos  = 127;
}
else {
  for (int i=0;i<4;i++) {
    // write the name
    char temp[15];
    pData[0]<i>.name  = (char *)malloc(15);
    pData[1]<i>.name  = (char *)malloc(15);
    pData[0]<i>.money = (char *)malloc(15);
    
    pack_fread(temp,15,file);
    strcpy(pData[0]<i>.name,temp);            // english name
65 
    pack_fread(temp,15,file);
    strcpy(pData[1]<i>.name,temp);            // chinese name
68 
    int win = pack_igetl(file);
    itoa(win,pData[0]<i>.money,10);            // money converted to C string
    pData[0]<i>.lev       = pack_igetl(file);    // level
    pData[0]<i>.pic       = pack_igetl(file);    // picture
    pData[0]<i>.scatterbrain = pack_igetl(file);    // scatterbrain
  }
  SBall.pos = pack_igetl(file);              // speed
  MBall.pos = pack_igetl(file);              // music
  FBall.pos = pack_igetl(file);              // sound fx
  language = pack_igetl(file);              // selected language
  stake    = pack_igetl(file);              // selected stake
}
SBall.y    = 218;
SBall.x    = get_ball_pos(100,SBall.pos);
MBall.y    = 263;
MBall.x    = get_ball_pos(255,MBall.pos);
FBall.y    = 308;
FBall.x    = get_ball_pos(255,FBall.pos);
87 
pack_fclose(file);
89}

Now this works exactly as it should do, with one strange problem. If I build the exe, export all the files to a seperate directory and run (including the packfile), it works. If I delete te packfile and run the exe, it crashes. Now I have included a check in the code, so it should not be doing this, it should simply load the default values.

A little twist to this problem, if I do exactly the same from within MSVC (i.e. delete the generated packfile) it works. Due to this I am unable to debug it and find out where the problem lies.

[EDIT]
Don't you just hate it when you spend hours trying to find the problem, make a post, then 2 minutes later fix it >:(

I did something a little stupid, I deleted the .dat file instead of the .set file. A little stupid I know, but they share the same icon, which I must now go and add code for to give it it's own icon.

Elverion

Member #6,239

September 2005

Maybe you should change your check to "if file exists" rather than !packfile_open. If the file is not found, it might return some non-zero number still and could be why you are having problems. It says it should return NULL in the manual, but who knows...

--
SolarStrike Software - MicroMacro home - Automation software.

Evert

Member #794

November 2000

Quote:

If the file is not found, it might return some non-zero number still and could be why you are having problems.

It doesn't return a number, it returns a pointer to a PACKFILE struct.

Quote:

It says it should return NULL in the manual, but who knows...

If it doesn't, it's a bug that should be fixed (but it actually does return NULL).

Quote:

I did something a little stupid, I deleted the .dat file instead of the .set file. A little stupid I know, but they share the same icon

You're not hiding the extensions, are you?

waldermort

Member #6,259

October 2005

Quote:

You're not hiding the extensions, are you?

Now that would be a good excuse, a good way to save a little face perhaps, but the answer is no :-[

I can't explain why I did it, perhaps I automaticaly deleted the last file in the list (which should be the last file created/added). But obviously i was wrong. This'l teach me to be a little more careful in the future.

One good thing to come out of this is noticing my failiure to code a check for the datafile.

I am now trying to find out how to manipulate the registry as to add an icon for these .set files.

Arthur Kalliokoski

Second in Command

February 2005

I've associated allegro programs with extensions by simply double clicking on them and when the "Open With" thing comes up, click on Browse to get to the program and make sure the "Always open with this program" is checked.

They all watch too much MSNBC... they get ideas.

waldermort

Member #6,259

October 2005

That would work, but only on your system. I don't want the users of my programs to be making these mistakes (not that they should be in those folders anyway). I just add a few lines of code to set the registry. Now those files have their own Icons and settings on all systems.