getpixel() and putpixel()

getpixel() and putpixel()

Jeff Bernard

Member #6,698

December 2005

I'm trying to make it so the player can customize the hero's colors. So, they choose the red, green, and blue values for the hero, then a function goes through and changes the colors. I would think my function works, but for some reason it doesn't. I've tried adding an obscene rest() when before putpixel() is executed, to see if it actually is, and it skipped the obscene rest()'s, so I assume it's a problem with checking for which color should be changed:

1void changeColors(int newR, int newG, int newB)
2{
 // check if the color actually needs to change
 if (newR != hero.r || newG != hero.g || newB != hero.b)
 {
    // change the color values for the hero
    hero.r = newR;
    hero.g = newG;
    hero.b = newB;
10 
    // load the bmp that has each hero sprite on it because it's 
    // half the amount of pixels as each frame (i stretch_blit)
    BITMAP* heroLibrary = load_bitmap("data\\hero.bmp", NULL);
14 
    // make sure the colors aren't default orange(255,128,64)
    if (hero.r != 255 && hero.g != 128 && hero.b != 64)
       for (int j = 0; j < heroLibrary->h; j++)
          for (int k = 0; k < heroLibrary->w; k++)
19 
             // this is my problem line...
             if (getr(getpixel(heroLibrary, k, j)) == 255 && 
                 getg(getpixel(heroLibrary, k, j)) == 128 && 
                 getb(getpixel(heroLibrary, k, j)) == 64)
24 
                // change the color?
                putpixel(heroLibrary, k, j, makecol(hero.r, hero.g, hero.b));
27 
    // put the hero sprites into it's array
    for (int i = 0; i < 16; i++)
       if (i < 8)
          stretch_blit(heroLibrary, hero.frame<i>, i*16, 0, 16, 16, 0, 0, 
                       hero.frame<i>->w, hero.frame<i>->h);
       else
          stretch_blit(heroLibrary, hero.frame<i>, (i-8)*16, 16, 16, 16, 0, 0,
                       hero.frame<i>->w, hero.frame<i>->h);
    destroy_bitmap(heroLibrary);
 }
38}

--
I thought I was wrong once, but I was mistaken.

CGamesPlay

Member #2,559

July 2002

if (newR != hero.r && newG != hero.g && newB != hero.b)Each of those should be OR. I.E. "if red is not the old red OR green is not...".

"data\\hero.bmp"That should be "data/hero.bmp"

Other than that it should work.

--
Tomasu: Every time you read this: hugging!

Ryan Patterson - <http://cgamesplay.com/>

Jeff Bernard

Member #6,698

December 2005

Ah, thanks, I didn't notice that with my first check. I've changed the AND to OR now.

As for the double backslash, that's how I load all of my files. It's essentially the same thing as a single forward slash. I just prefer the double backslash because Windows uses backslashes in their address for folders.

I've made the change on the first line...but it still doesn't seem to reach putpixel().

EDIT-- I fixed the problem. Simple mistake in my code.

--
I thought I was wrong once, but I was mistaken.