connect: Transport endpoint is already connected

connect: Transport endpoint is already connected

Cody Harris

Member #4,406

March 2004

Here's the code:

if (!isconnected){
        printf("Connecting to %s\n",inet_ntoa(outlink_addr.sin_addr));
              if (connect(outsock, (struct sockaddr *)&outlink_addr,sizeof(struct sockaddr)) == -1) {
          perror("connect");
          //close(outsock);  
          //exit(1);
        }else{
          printf("Connected to %s (%d)\n",inet_ntoa(outlink_addr.sin_addr),outsock);
          FD_SET(outsock, &master); // add to master set
          if (outsock > fdmax) {    // keep track of the maximum
            outsock = newfd;
          }
          isconnected = 1;
        }
      }

And the output:

Quote:

Unreal2Hybrid: new connection from 192.168.0.2 on socket 4
Connecting to 63.110.124.45
connect: Transport endpoint is already connected

I can't figure out why it can't reconnect (it connects once, and only once, do I need to reset the struct or something?).

And yes, this is using select, a modified select thingy from Beej. If you want I can post the entire code...

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.

Thomas Fjellstrom

Member #476

June 2000

Theres a nice option called something like: SO_REUSEADDR.

--
Thomas Fjellstrom - [website] - [email] - [Allegro Wiki] - [Allegro TODO]
"If you can't think of a better solution, don't try to make a better solution." -- weapon_S
"The less evidence we have for what we believe is certain, the more violently we defend beliefs against those who don't agree" -- https://twitter.com/neiltyson/status/592870205409353730

ReyBrujo

Moderator

January 2001

Most probably the problem is in the bind, not the connect.

It is an operative system issue. If you don't close the socket correctly (in example, press CTRL-C to end the program), the port is never freed. In Linux there used to be a delay of around 30 seconds-1 minute until the OS freed the socket and you were able to bind it again.

--
RB
光子「あたしただ…奪う側に回ろうと思っただけよ」
Mitsuko's last words, Battle Royale

Cody Harris

Member #4,406

March 2004

Adding

        if (setsockopt(outsock, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(int)) == -1) {
            perror("setsockopt");
            exit(1);
        }

didn't work, it still complains... Do I have to reset the struct or something...

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.

Thomas Fjellstrom

Member #476

June 2000

Heres a little function I found and modified:

1int make_socket (unsigned short port)
2{
 int sock, yes = 1;
 struct sockaddr_in name;
5 
 /* Create the socket. */
 sock = socket (PF_INET, SOCK_STREAM, 0);
 if (sock < 0) {
    /*char *buf = calloc(1, 256);
    if(!buf)
       exit (EXIT_FAILURE);
    */
    log_printf(global_log, LOG_LEVEL_FATAL, "socket: failed..."/*, strerror_r(errno, buf, 256)*/);
    //free(buf);
    exit (EXIT_FAILURE);
 }
 if (setsockopt(sock,SOL_SOCKET,SO_REUSEADDR,(const char *)&yes,sizeof(int)) == -1) {
    /*char *buf = calloc(1, 256);
    if(!buf)
       exit (EXIT_FAILURE);
    */
    log_printf(global_log, LOG_LEVEL_FATAL, "setsockopt: failed..."/*, strerror_r(errno, buf, 256)*/);
    //free(buf);
    exit (EXIT_FAILURE);
 }
26 
 /* Give the socket a name. */
 name.sin_family = AF_INET;
 name.sin_port = htons (port);
 name.sin_addr.s_addr = htonl (INADDR_ANY);
 if (bind (sock, (struct sockaddr *) &name, sizeof (name)) < 0) {
    char *buf = calloc(1, 256);
    if(!buf)
       exit (EXIT_FAILURE);
35 
    log_printf(global_log, LOG_LEVEL_FATAL, "bind: failed..."/*, strerror_r(errno, buf, 256)*/);
    //free(buf);
    exit (EXIT_FAILURE);
 }
40 
 log_printf(global_log, LOG_LEVEL_NOTE, "Succsessfully bound to port: %i", port);
42 
 return sock;
44}

The log_* functions are mine, not libc or anything... Oh, and note, this is for a server style port IIRC.

ReyBrujo

Moderator

January 2001

How is the server code? It is listening for more connections?

--
RB
光子「あたしただ…奪う側に回ろうと思っただけよ」
Mitsuko's last words, Battle Royale

Cody Harris

Member #4,406

March 2004

The server listens for connections, and if it find that when a client connects that it's not connected to another server, then it connects to it...

I want it to reconnect to that socket if the connection is lost.

EDIT: Why do you have to bind when connecting to something else?

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.

ReyBrujo

Moderator

January 2001

The code is old, you don't want to open a new port everytime you connect to something

You should show the server code, though. The client should not have problem no matter how many they are.

--
RB
光子「あたしただ…奪う側に回ろうと思っただけよ」
Mitsuko's last words, Battle Royale

Cody Harris

Member #4,406

March 2004

I edited it so that it recalled the socket thingy...

    if (!isconnected){
      printf("Connecting to %s (cached)\n",inet_ntoa(outlink_addr.sin_addr));
            if (connect(outsock, (struct sockaddr *)&outlink_addr,sizeof(struct sockaddr)) == -1) {
        perror("connect");
        if ((outlink=gethostbyname("palace.morphforest.com")) == NULL){
          perror("gethostbyname");
          exit(1);
        }
        if ((outsock = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
          perror("socket");
          exit(1);
        }
        outlink_addr.sin_family = AF_INET;    // host byte order 
        outlink_addr.sin_port = htons(7029);  // short, network byte order 
        outlink_addr.sin_addr = *((struct in_addr *)outlink->h_addr);
        memset(&(outlink_addr.sin_zero), '\0', 8);  // zero the rest of the
17 
        // lose the pesky "address already in use" error message
        if (setsockopt(outsock, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(int)) == -1) {
          perror("setsockopt");
          exit(1);
        }
        printf("Connecting to %s (last attempt)\n",inet_ntoa(outlink_addr.sin_addr));
        if (connect(outsock, (struct sockaddr *)&outlink_addr,sizeof(struct sockaddr)) == -1) {
          perror("connect");
          exit(1);
        }else{
          printf("Connected to %s (%d)\n",inet_ntoa(outlink_addr.sin_addr),outsock);
          FD_SET(outsock, &master); // add to master set
          if (outsock > fdmax) {    // keep track of the maximum
            outsock = newfd;
          }
          isconnected = 1;
        }
        //close(outsock);  
        //exit(1);
      }else{
        printf("Connected to %s (%d)\n",inet_ntoa(outlink_addr.sin_addr),outsock);
        FD_SET(outsock, &master); // add to master set
        if (outsock > fdmax) {    // keep track of the maximum
          outsock = newfd;
        }
        isconnected = 1;
      }
    }

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.

ReyBrujo

Moderator

January 2001

Hmm... close the old socket before creating a new one. And you meant reusing a socket to connect? Ah... I misunderstood, sorry.

--
RB
光子「あたしただ…奪う側に回ろうと思っただけよ」
Mitsuko's last words, Battle Royale

Cody Harris

Member #4,406

March 2004

The old one is automatically closed on error or disconnect.

This seems to work though.

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.

ReyBrujo

Moderator

January 2001

Hmm... really? It frees the descriptor? Geez... it must have changed since the last time I did some real network programming then...

--
RB
光子「あたしただ…奪う側に回ろうと思っただけよ」
Mitsuko's last words, Battle Royale

Cody Harris

Member #4,406

March 2004

Yeah, it reuses file descriptors, the lowest one free (hense if you close stout and open a new file, all stout will go to the file...

That's the logic between piping stout, you close it then you ddup it or whatever...

---------------------------------
Homepage - Art (Photography)
I'm QBasicer on #allegro on Freenode.