This f***ing enemy won't move!

no-reply@allegro.cc (DJLad16) — Sun, 24 Feb 2013 00:21:03 +0000

I've been at this for quite some time now, and I still can't get it to work. My problem is that I created a second enemy and I wanted him moving on another platform. So for the sake of typing less code, I modified initEnemy(), updateEnemy(); so I only need to type it out once. And not do initEnemy2, initEnemy3 etc. When I finally went to putting the code in, the enemy wouldn't move. I tried tinkering around with it for a while with no results. So I resorted to doing initEnemy2, drawEnemy2 etc. I was thinking this should work 100% - it didn't. Went back to the original way, and I found out that changing enemy2 co-ordinates to the same as the enemy IT WOULD MOVE! But when I put it back to the co-ordinates I want it to be, IT WOULDN'T MOVE! And after that I had absolutely no idea what was going on. (I've removed some code for file size error, and any irrelevant code)

#SelectExpand
   1//Prototpyes
   2void initPlayer(Player &player);
   3
   4
   5void initEnemy(Enemy &enemy, int x, int y);
   6void drawEnemy(Enemy &enemy, ALLEGRO_BITMAP *image);
   7void updateEnemy(Enemy &enemy, int posX, int posX2);
   8bool collideArrow(Enemy &enemy, Arrow &arrow, bool eLive, bool aLive);
   9
  10void initCoin(Coin &coin, int x, int y);
  11void drawCoin(Coin &coin, ALLEGRO_BITMAP *image);
  12bool coinCollide(Coin &coin,Player &player ,int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, bool live, int coinCount);
  13
  14void initArrow(Arrow &arrow);
  15void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2);
  16void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot);
  17void updateArrow(Arrow &arrow);
  18
  19void initKey(Key &key);
  20void drawKey(Key &key, ALLEGRO_BITMAP *image);
  21
  22bool collision(Player &player, int ex, int ey, int eWidth, int eHeight, int pWidth, int pHeight);
  23
  24void cameraUpdate(float *cameraPosition,Player &player, float width, float height);
  25
  26//Global Variables
  27enum direction {LEFT, RIGHT};
  28int dir = LEFT;
  29const int NUM_ENEMY = 10;
  30int groundHeight = 545;
  31bool fired = false, firedR = false, firedL = false;
  32bool coinLive = false;
  33bool left, right = false;
  34const float gravity = 1;
  35
  36int main()
  37{
  38
Player player;
Enemy enemy;
Enemy enemy2;
Coin coin;
Coin coin2;
Arrow arrow;
Key key;
bool done = false, active = false, draw = true;
bool jump = false;
bool gotKey = false;
int sourceX = 32, sourceY = 0;
int coinCount = 0;
const float FPS = 60.0;
const float frameFPS = 15.0;
float jumpSpeed = 15.0;
float velX = 0, velY = 0;

float cameraPosition[2] = {0,0};
  57
initPlayer(player);
initEnemy(enemy, 86, 391);
initEnemy(enemy2, 1162, 338);
initArrow(arrow);
initCoin(coin, 550, 480);
initCoin(coin2, 120, 395);
initKey(key);
  65
ALLEGRO_KEYBOARD_STATE keystate;
ALLEGRO_TRANSFORM camera;
ALLEGRO_TRANSFORM identity;
ALLEGRO_SAMPLE *coinCollect = al_load_sample("Files/coin collect sound.wav");
ALLEGRO_SAMPLE *bowShot = al_load_sample("Files/bow sound effect.wav");
ALLEGRO_SAMPLE *bgSong = al_load_sample("Files/Background song.wav");
ALLEGRO_SAMPLE *keyCollection = al_load_sample("Files/key collection.wav");
ALLEGRO_SAMPLE_INSTANCE *songInstance = al_create_sample_instance(bgSong);
ALLEGRO_BITMAP *enemyImg = al_load_bitmap("Files/enemy.png");
ALLEGRO_BITMAP *background2 = al_load_bitmap("Files/Background.png");
ALLEGRO_BITMAP *character = al_load_bitmap("Files/spritesheet(Bow & left + right).png");
ALLEGRO_BITMAP *arrow_r = al_load_bitmap("Files/Arrow(RIGHT).png");
ALLEGRO_BITMAP *arrow_l = al_load_bitmap("Files/Arrow(LEFT).png");
ALLEGRO_BITMAP *coinImg = al_load_bitmap("Files/coin2.png");
ALLEGRO_BITMAP *keyImg = al_load_bitmap("Files/key.png");
ALLEGRO_BITMAP *ground = al_load_bitmap("Files/Ground.png");
ALLEGRO_FONT *numArrow = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_FONT *fps = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_FONT *numCoin = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_FONT *random = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_FONT *lives = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_TIMER *timer = al_create_timer(1.0/FPS);
ALLEGRO_TIMER *frameTimer = al_create_timer(1.0/frameFPS);
ALLEGRO_EVENT_QUEUE *event_queue = al_create_event_queue();
  90
al_reserve_samples(4); //Respresents how many audio clips I have in the game
  92
al_set_sample_instance_playmode(songInstance, ALLEGRO_PLAYMODE_LOOP);
al_attach_sample_instance_to_mixer(songInstance, al_get_default_mixer());
al_set_window_title(display, "Australian Outback");
al_register_event_source(event_queue, al_get_keyboard_event_source());
al_register_event_source(event_queue, al_get_timer_event_source(timer));
al_register_event_source(event_queue, al_get_timer_event_source(frameTimer));
al_register_event_source(event_queue, al_get_display_event_source(display));

al_play_sample_instance(songInstance);
 102
al_start_timer(timer);
al_start_timer(frameTimer);
while(!done)
{
  ALLEGRO_EVENT event;
  al_wait_for_event(event_queue, &event);
  al_get_keyboard_state(&keystate);
    
  if(al_key_down(&keystate, ALLEGRO_KEY_ESCAPE))
  {
    done = true;
  }
  else if(event.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
  {
    done = true;
  }
  
  
  else if(event.type == ALLEGRO_EVENT_TIMER)
  {
    if(event.timer.source == timer)
    {
      active = true;
      updateArrow(arrow);
      updateEnemy(enemy, 238, 78);
      updateEnemy(enemy2, 1162, 1229);
 129
      if(al_key_down(&keystate, ALLEGRO_KEY_D))
      {
        velX = player.speed;
        dir = RIGHT;
      
      }
      else if(al_key_down(&keystate, ALLEGRO_KEY_A))
      {
        velX = -player.speed;
        dir = LEFT;
      }
      else 
      {
        velX = 0;
        active = false;
      }
      if(al_key_down(&keystate, ALLEGRO_KEY_W) && jump)
      {
        velY = -jumpSpeed;
        jump = false;
      }
    }
    else if(event.timer.source = frameTimer)
    {
      if(active)
      {
        sourceX += al_get_bitmap_width(character) / 3;
      }
      else 
      {
        sourceX = 32; 
      }
      if(sourceX >= al_get_bitmap_width(character))
      {
        sourceX = 0;
      }
        sourceY = dir;

      
    }
    
      if(!jump)
        velY += gravity;
      else
        velY = 0;
        player.x += velX;
        player.y += velY;
    
        jump = (player.y >= groundHeight);
 179
        if(jump)
        {
              player.y = groundHeight;
        }  draw = true;
    
 185
    cameraUpdate(cameraPosition, player, 32, 32);
    al_identity_transform(&camera);
    al_translate_transform(&camera, -cameraPosition[0], -cameraPosition[1]);
    al_use_transform(&camera);
 190
  }
  
  if(al_key_down(&keystate, ALLEGRO_KEY_SPACE))
  {
    fireArrow(arrow, player, bowShot);
  }
  
  if(coinCollide(coin, player, coin.x, coin.y, coin.width, coin.height, 32, 32, coinLive, coinCount))
  {
    coin.live = false;
    ++coinCount;
    coin.x = -500;
    coin.y = -500;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(coinCollide(coin2, player, coin2.x, coin2.y, coin2.width, coin2.height, 32, 32, coinLive, coinCount))
  {
    coin.live = false;
    ++coinCount;
    coin2.x = -500;
    coin2.y = -500;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(collision(player, key.x, key.y, key.width, key.height, 32, 32))//Collide with key
  {
    al_play_sample(keyCollection, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
    key.x = -500;
    key.y = -500;
    key.live = false;
  }
  if(collision(player, enemy.x, enemy.y, enemy.width, enemy.height, 32, 32))//Player collision with enemy
  {
    player.x = 10;
    player.y = 546;
    --player.lives;
    arrow.live = false;
    dir = RIGHT;
  }
  
  if(collideArrow(enemy, arrow, enemy.live, arrow.live))
  {
    enemy.live = false;
    enemy.x = 0;
    enemy.y = 0;
    arrow.live = false;
    gotKey = true;
    ++player.score;
  } 
 239
if(draw && al_is_event_queue_empty(event_queue))
{
  draw = false;
  al_draw_bitmap(background2, 0, 0, 0);
  al_draw_bitmap_region(character, sourceX, sourceY * al_get_bitmap_height(character) / 2, 32, 32, player.x, player.y, 0);
  drawKey(key, keyImg);
  drawArrow(arrow, arrow_r, arrow_l);
  drawCoin(coin, coinImg);
  drawCoin(coin2, coinImg);
  drawEnemy(enemy, enemyImg);
  drawEnemy(enemy2, enemyImg);
  al_identity_transform(&identity);
  al_use_transform(&identity);
  al_draw_textf(numArrow, al_map_rgb(252,209, 22), 10, 10, 0, "Arrows: %i", arrow.arrowCount);
  al_draw_textf(numCoin, al_map_rgb(252, 209, 22), 10, 50, 0, "Coins: %i", coinCount);
  al_draw_textf(lives, al_map_rgb(252, 209, 22), 110, 10, 0, "Lives: %i", player.lives);
  //al_draw_textf(fps, al_map_rgb(252, 209, 22), 110, 50, 0, "FPS: %i", FPS);
  al_flip_display();
  al_clear_to_color(al_map_rgb(255, 255, 255));
 259
}
}
 262
 263
 264}
 265void initPlayer(Player &player)
 266{
player.x = 1162;
player.y = 545;
player.lives = 3;
player.speed = 5;
player.score = 0;
dir = RIGHT;
 273}
 274
 275void initEnemy(Enemy &enemy, int x, int y)
 276{
enemy.live = true;
enemy.speedR = 2;
enemy.speedL = -2;
enemy.speed = 2;
enemy.x = x;
enemy.y = y;
enemy.width = 29;
enemy.height = 29;
 285}
 286void drawEnemy(Enemy &enemy, ALLEGRO_BITMAP *image)
 287{
  if(enemy.live)
  {
    al_draw_bitmap(image, enemy.x, enemy.y, 0);
  }
 292}
 293void updateEnemy(Enemy &enemy, int posX, int posX2)
 294{
if(enemy.live)
{
  enemy.x += enemy.speed;
    if(enemy.x >= posX)
    {
      enemy.x = posX;
      enemy.speed = enemy.speedL;
    }
    if(enemy.x <= posX2)
    {
      enemy.x = posX2;
      enemy.speed = enemy.speedR;
    }
}
 309}
 310
 311void initArrow(Arrow &arrow)
 312{
  arrow.speed = 4.0;
  arrow.live = false;
  arrow.arrowCount = 10;  
  arrow.width = 16;
  arrow.height = 5;
  arrow.aVelX = 0; 
  arrow.aVelY = 0;
 320}
 321void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2)
 322{
  if(arrow.live && dir == RIGHT)
  {
    al_draw_bitmap(image, arrow.x, arrow.y, 0);
  }
  if(arrow.live && dir == LEFT)
  {
    al_draw_bitmap(image2, arrow.x, arrow.y, 0);
  }
  
 332}
 333void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot)
 334{
  if(!arrow.live)
  {
    --arrow.arrowCount;
    arrow.live = true;
    arrow.x = player.x + 17;
    arrow.y = player.y + 22;
    fired = true;
    al_play_sample(bowShot, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
    
  }

 346}
 347void updateArrow(Arrow &arrow)
 348{
  if(arrow.live && fired)
  {
    if(dir == RIGHT)
    {
      arrow.x += arrow.speed;
    }
    if(dir == LEFT)
    {
      arrow.x -= arrow.speed;
    }
      if(arrow.x >=  2000 - 10)
      {
        arrow.live = false;
      }
      if(arrow.x <= 0 + 3)
      {
        arrow.live = false;
      }
      else if(arrow.arrowCount <= 0)
      {
        fired = false;
      }
  
  }
 373}

no-reply@allegro.cc (Dizzy Egg) — Sun, 24 Feb 2013 05:34:45 +0000

I only read the first couple of lines, but since no-one else has answered can I suggest you Google "class arrays" or "arrays". Basically you'll have an array of instances of your class, that you'll cycle through using a 'for' loop or similar, so you don't have to write enemy_1, enemy_2, enemy_3 etc etc etc.

It'll look something like:

for(int i=0;i=TOTAL_ENEMIES;i++){
  enemy[i]->doSomething();
}

and that will go through all your enemies! If you want more help just ask, the Allegroids are AWESOME when they get their teeth stuck in!

no-reply@allegro.cc (Specter Phoenix) — Sun, 24 Feb 2013 08:31:20 +0000

Do you really need that many font declarations that point to the exact same font data? If you are going to use the same font why not just make one, load it, then use it across all the things that need that font rather than use memory to hold the same data.

As for movement, I agree with Dizzy on this one.

no-reply@allegro.cc (Schyfis) — Sun, 24 Feb 2013 10:15:25 +0000

Let's see what happens when you call updateEnemy(enemy2, 1162, 1229).

#SelectExpand
  1//the first call to updateEnemy for enemy2 will go like this:
  2void updateEnemy(Enemy &enemy, int posX, int posX2)
  3{
if(enemy.live) //enemy2.live is true, so enter block
{
  enemy.x += enemy.speed; //1162 + 2. enemy2.x is now 1164
    if(enemy.x >= posX) //1164 >= posX, so enter block
    {
      enemy.x = posX; //enemy.x is now 1162
      enemy.speed = enemy.speedL; //enemy.speed is now -2
    }
    if(enemy.x <= posX2) //1162 <= posX2, so enter block
    {
      enemy.x = posX2; //enemy.x is now 1229
      enemy.speed = enemy.speedR; //enemy.speed is now 2
    }
}
 18}
 19
 20//the second and all future calls to updateEnemy for enemy2 will go like this:
 21void updateEnemy(Enemy &enemy, int posX, int posX2)
 22{
if(enemy.live) //enemy2.live is true, so enter block
{
  enemy.x += enemy.speed; //1229 - 2. enemy2.x is now 1227
    if(enemy.x >= posX) //1227 >= posX, so enter block
    {
      enemy.x = posX; //enemy.x is now 1162
      enemy.speed = enemy.speedL; //enemy.speed is now -2
    }
    if(enemy.x <= posX2) //1162 <= posX2, so enter block
    {
      enemy.x = posX2; //enemy.x is now 1229
      enemy.speed = enemy.speedR; //enemy.speed is now 2
    }
}
 37}

Long story short, your enemy will always be stuck at 1229 because of the input to the function.

How about giving the Enemy struct a minimum_x and a maximum_x? I think it would make your life easier.

You will definitely benefit from Dizzy's suggestion. Simplification like that will lead to a lot less code, which means a lot less confusion. If you keep your enemies (and other game objects, for that matter) in arrays, you can keep track of them and update them in one stroke. You can even do collision functions for all of them in one loop, instead of writing something like:

if(collision(player, enemy1))
if(collision(player, enemy2))
if(collision(player, enemy3))
//...
if(collision(player, enemy498))
if(collision(player, enemy499))
if(collision(player, enemy500))

no-reply@allegro.cc (DJLad16) — Mon, 25 Feb 2013 00:33:04 +0000

Here's what I did with class arrays. However, I couldn't get the first enemy to draw, so I instantiated and new enemy object Enemy enemy2[NUM_ENEMY];. But instantiating a new enemy kind of contradicts the idea of class arrays because I still need to do collision for each enemy. (It wouldn't let me post a reply for some reason, so I just had to edit this post)

#SelectExpand
   1nclude <allegro5/allegro.h>
   2#include 
   3#include 
   4#include 
   5#include 
   6#include 
   7#include 
   8#include 
   9#include 
  10#include 
  11#include "objects.h"
  12
  13#define ScreenWidth 800
  14#define ScreenHeight 600
  15
  16
  17//////////////////////////////////////
  18//    SORT OUT ARROW PROBLEM      //
  19//////////////////////////////////////
  20
  21
  22//Prototpyes
  23void initPlayer(Player &player);
  24
  25
  26void initEnemy(Enemy enemy[], int x, int y, int numEnemy);
  27void drawEnemy(Enemy enemy[], ALLEGRO_BITMAP *image, int numEnemy);
  28void updateEnemy(Enemy enemy[], int posX, int posX2, int numEnemy);
  29bool collideArrow(Enemy enemy[], Arrow &arrow, bool eLive, bool aLive, int numEnemy);
  30
  31void initCoin(Coin &coin, int x, int y);
  32void drawCoin(Coin &coin, ALLEGRO_BITMAP *image);
  33bool coinCollide(Coin &coin,Player &player ,int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, bool live, int coinCount);
  34
  35void initArrow(Arrow &arrow);
  36void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2);
  37void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot);
  38void updateArrow(Arrow &arrow);
  39
  40void initKey(Key &key);
  41void drawKey(Key &key, ALLEGRO_BITMAP *image);
  42
  43bool collision(Player &player, int ex, int ey, int eWidth, int eHeight, int pWidth, int pHeight);
  44
  45void cameraUpdate(float *cameraPosition,Player &player, float width, float height);
  46
  47//Global Variables
  48enum direction {LEFT, RIGHT};
  49int dir = LEFT;
  50const int NUM_ENEMY = 2;
  51bool fired = false, firedR = false, firedL = false;
  52bool coinLive = false;
  53bool left, right = false;
  54const float gravity = 1;
  55
  56int main()
  57{
ALLEGRO_DISPLAY *display;
  59
if(!al_init())
{
  al_show_native_message_box(0, 0, "Error", "Falied to initialize allegro", 0, 0);
  return -1;
}

display = al_create_display(ScreenWidth, ScreenHeight);
  67
if(!display)
{
  al_show_native_message_box(0, 0, "Error", "Falied to initialize the display", 0, 0);
  return -1;
}
  73
Player player;
Enemy enemy[NUM_ENEMY];
Enemy enemy2[NUM_ENEMY];
Coin coin;
Coin coin2;
Arrow arrow;
Key key;
int groundHeight = 535;
bool done = false, active = false, draw = true;
bool jump = false;
bool gotKey = false;
int sourceX = 32, sourceY = 0;
int coinCount = 0;
const float FPS = 60.0;
const float frameFPS = 15.0;
float jumpSpeed = 15.0;
float velX = 0, velY = 0;

float cameraPosition[2] = {0,0};
  93

  95
al_init_image_addon();
al_init_primitives_addon();
al_install_keyboard();
al_init_font_addon();
al_init_ttf_addon();
al_install_audio();
al_init_acodec_addon();
 103
initPlayer(player);
initEnemy(enemy, 86, 391, NUM_ENEMY);
initEnemy(enemy2, 1167, 333, NUM_ENEMY);
initArrow(arrow);
initCoin(coin, 550, 480);
initCoin(coin2, 120, 398);
initKey(key);
 111
ALLEGRO_KEYBOARD_STATE keystate;
ALLEGRO_TRANSFORM camera;
ALLEGRO_TRANSFORM identity;
ALLEGRO_SAMPLE *coinCollect = al_load_sample("Files/coin collect sound.wav");
ALLEGRO_SAMPLE *bowShot = al_load_sample("Files/bow sound effect.wav");
ALLEGRO_SAMPLE *bgSong = al_load_sample("Files/Background song 2.wav");
ALLEGRO_SAMPLE *keyCollection = al_load_sample("Files/key collection.wav");
ALLEGRO_SAMPLE *crocSound = al_load_sample("Files/Crocodile sound effect.wav");
ALLEGRO_SAMPLE_INSTANCE *songInstance = al_create_sample_instance(bgSong);
ALLEGRO_BITMAP *enemyImg = al_load_bitmap("Files/enemy.png");
ALLEGRO_BITMAP *background2 = al_load_bitmap("Files/Background 2.png");
ALLEGRO_BITMAP *character = al_load_bitmap("Files/spritesheet(Bow & left + right).png");
ALLEGRO_BITMAP *arrow_r = al_load_bitmap("Files/Arrow(RIGHT).png");
ALLEGRO_BITMAP *arrow_l = al_load_bitmap("Files/Arrow(LEFT).png");
ALLEGRO_BITMAP *coinImg = al_load_bitmap("Files/coin2.png");
ALLEGRO_BITMAP *keyImg = al_load_bitmap("Files/key.png");
ALLEGRO_BITMAP *ground = al_load_bitmap("Files/Ground.png");
ALLEGRO_FONT *font = al_load_font("Files/JUNGBN__.TTF", 23, 0);
ALLEGRO_TIMER *timer = al_create_timer(1.0/FPS);
ALLEGRO_TIMER *frameTimer = al_create_timer(1.0/frameFPS);
ALLEGRO_EVENT_QUEUE *event_queue = al_create_event_queue();
 133
al_reserve_samples(5); //Respresents how many audio clips I have in the game
 135
al_set_sample_instance_playmode(songInstance, ALLEGRO_PLAYMODE_LOOP);
al_attach_sample_instance_to_mixer(songInstance, al_get_default_mixer());
al_set_window_title(display, "Australian Outback");
al_register_event_source(event_queue, al_get_keyboard_event_source());
al_register_event_source(event_queue, al_get_timer_event_source(timer));
al_register_event_source(event_queue, al_get_timer_event_source(frameTimer));
al_register_event_source(event_queue, al_get_display_event_source(display));

//al_play_sample_instance(songInstance);
 145
al_start_timer(timer);
al_start_timer(frameTimer);
while(!done)
{
  ALLEGRO_EVENT event;
  al_wait_for_event(event_queue, &event);
  al_get_keyboard_state(&keystate);
    
  if(al_key_down(&keystate, ALLEGRO_KEY_ESCAPE))
  {
    done = true;
  }
  else if(event.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
  {
    done = true;
  }
  
  
  else if(event.type == ALLEGRO_EVENT_TIMER)
  {
    if(event.timer.source == timer)
    {
      active = true;
      updateArrow(arrow);
      updateEnemy(enemy, 238, 78, NUM_ENEMY);
      updateEnemy(enemy2, 1236, 1167, NUM_ENEMY);
 172
      if(al_key_down(&keystate, ALLEGRO_KEY_D))
      {
        velX = player.speed;
        dir = RIGHT;
      
      }
      else if(al_key_down(&keystate, ALLEGRO_KEY_A))
      {
        velX = -player.speed;
        dir = LEFT;
      }
      else 
      {
        velX = 0;
        active = false;
      }
      if(al_key_down(&keystate, ALLEGRO_KEY_W) && jump)
      {
        velY = -jumpSpeed;
        jump = false;
      }
    }
    else if(event.timer.source = frameTimer)
    {
      if(active)
      {
        sourceX += al_get_bitmap_width(character) / 3;
      }
      else 
      {
        sourceX = 32; 
      }
      if(sourceX >= al_get_bitmap_width(character))
      {
        sourceX = 0;
      }
        sourceY = dir;

      
    }
    
      if(!jump)
        velY += gravity;
      else
        velY = 0;
        player.x += velX;
        player.y += velY;
    
        jump = (player.y >= groundHeight);
 222
        if(jump)
        {
              player.y = groundHeight;
        }  draw = true;
    
 228
    cameraUpdate(cameraPosition, player, 32, 32);
    al_identity_transform(&camera);
    al_translate_transform(&camera, -cameraPosition[0], -cameraPosition[1]);
    al_use_transform(&camera);
 233
  }
  
  if(al_key_down(&keystate, ALLEGRO_KEY_SPACE))
  {
    fireArrow(arrow, player, bowShot);
  }
  if(collision(player, 371, 470, 325, 30, 32, 32))//First Platform (long)
  {
    if(player.y > 470)
    {
      groundHeight = 470;
      player.y = groundHeight;
      player.y += velY;
    }
  }  
  else if(collision(player, 70, 390, 200, 38, 32, 32))//Second Platform (short)
  {
    groundHeight = 390;
    player.y = groundHeight;
    player.y += velY;
  }
  else if(collision(player, 79, 275, 200, 30, 32, 32))//Third Platform (short)
  {
    if(player.y > 275)
    {
      groundHeight = 275;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 313, 220, 250, 30, 32, 32))//Fourth Platform (Medium)
  {
    if(player.y > 220)
    {
      groundHeight = 220;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 655, 165, 36, 30, 32, 32))//Fifth Platform (first tiny)
  {
    if(player.y > 165)
    {
      groundHeight = 165;
      player.y = groundHeight;
      player.y += velY;  
    }
  }
  else if(collision(player, 582, 70, 33, 30, 32, 32))//Sixth Platform (second tiny)
  {
    if(player.y > 70)
    {
      groundHeight = 70;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 763, 30, 36, 30, 32, 32))//Seventh Platform (third tiny)
  {
    if(player.y > 30)
    {
      groundHeight = 30;
      player.y = groundHeight;
      player.y += velY;
    }      
  }
  else if(collision(player, 926, 77, 200, 38, 32, 32))//Eighth Platform (short)
  {
    if(player.y > 77)
    {
      groundHeight = 77;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 926, 150, 200, 38, 32, 32))//Ninth platform (short)
  {
    if(player.y > 150)
    {
      groundHeight = 150;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 1202, 120, 36, 30, 32, 32))//Tenth platform (fourth tiny)
  {
    if(player.y > 120)
    {
      groundHeight = 120;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 1162, 335, 118, 38, 32, 32))//11th Platform (first short medium)
  {
    if(player.y > 335)
    {
      groundHeight = 335;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 1045, 327, 36, 30, 32, 32))//12th Platform (fifth tiny)
  {
    if(player.y > 327)
    {
      groundHeight = 327;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else if(collision(player, 916, 327, 36, 30, 32, 32))//13th Platform (sixth tiny)
  {
    if(player.y > 327)
    {
      groundHeight = 327;
      player.y = groundHeight;
      player.y += velY;
    }
  }
  else
  {
    groundHeight = 535;
  }

#SelectExpand
   1if(coinCollide(coin, player, coin.x, coin.y, coin.width, coin.height, 32, 32, coinLive, coinCount))
  {
    coin.live = false;
    ++coinCount;
    coin.x = -500;
    coin.y = -500;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(coinCollide(coin2, player, coin2.x, coin2.y, coin2.width, coin2.height, 32, 32, coinLive, coinCount))
  {
    coin2.live = false;
    ++coinCount;
    coin2.x = -500;
    coin2.y = -500;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(collision(player, key.x, key.y, key.width, key.height, 32, 32))//Collide with key
  {
    al_play_sample(keyCollection, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
    key.x = -500;
    key.y = -500;
    key.live = false;
    gotKey = true;
  }
  /*if(collision(player, enemy.x, enemy.y, enemy.width, enemy.height, 32, 32))//Player collision with enemy
  {
    player.x = 10;
    player.y = 546;
    --player.lives;
    arrow.live = false;
    dir = RIGHT;
  }
  if(collision(player, enemy2.x, enemy2.y, enemy2.width, enemy2.width, 32, 32))//Player collision with enemy
  {
    player.x = 10;
    player.y = 546;
    --player.lives;
    arrow.live = false;
    dir = RIGHT;
  }*/
  if(collision(player, 1220, 535, 90, 61, 32, 32))//Crocodile collision
  {
    player.x = 10;
    player.y = 535;
    --player.lives;
  }
  if(player.x == 1090 && player.y == 535)
  {
    al_play_sample(crocSound, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  /*if(collideArrow(enemy, arrow, enemy.live, arrow.live))//Arrow Collision with enemy
  {
    enemy.live = false;
    enemy.x = 0;
    enemy.y = 0;
    arrow.live = false;
    ++player.score;
  }
  if(collideArrow(enemy2, arrow, enemy2.live, arrow.live))//Arrow Collision with enemy
  {
    enemy2.live = false;
    enemy2.x = 0;
    enemy2.y = 0;
    arrow.live = false;
    ++player.score;
  }*/

if(draw && al_is_event_queue_empty(event_queue))
{
  draw = false;
  al_draw_bitmap(background2, 0, 0, 0);
  al_draw_bitmap_region(character, sourceX, sourceY * al_get_bitmap_height(character) / 2, 32, 32, player.x, player.y, 0);
  drawKey(key, keyImg);
  drawArrow(arrow, arrow_r, arrow_l);
  drawCoin(coin, coinImg);
  drawCoin(coin2, coinImg);
  drawEnemy(enemy, enemyImg, NUM_ENEMY);
  drawEnemy(enemy2, enemyImg, NUM_ENEMY);
  al_identity_transform(&identity);
  al_use_transform(&identity);
  al_draw_textf(font, al_map_rgb(252,209, 22), 10, 10, 0, "Arrows: %i", arrow.arrowCount);
  al_draw_textf(font, al_map_rgb(252, 209, 22), 10, 50, 0, "Coins: %i", coinCount);
  al_draw_textf(font, al_map_rgb(252, 209, 22), 110, 10, 0, "Lives: %i", player.lives);
  //al_draw_textf(fps, al_map_rgb(252, 209, 22), 110, 50, 0, "FPS: %i", FPS);
  al_flip_display();
  al_clear_to_color(al_map_rgb(255, 255, 255));
  87
}
}
  90
al_destroy_bitmap(character);
al_destroy_bitmap(ground);
al_destroy_bitmap(coinImg);
al_destroy_bitmap(background2);
al_destroy_bitmap(arrow_l);
al_destroy_bitmap(arrow_r);
al_destroy_bitmap(keyImg);
al_destroy_sample(coinCollect);
al_destroy_sample(bowShot);
al_destroy_sample(bgSong);
al_destroy_sample(keyCollection);
al_destroy_sample_instance(songInstance);
al_destroy_font(font);
al_destroy_display(display);
al_destroy_event_queue(event_queue);
al_destroy_timer(timer);
return 0;
 108}
 109void initPlayer(Player &player)
 110{
player.x = 10;
player.y = 535;
player.lives = 3;
player.speed = 5;
player.score = 0;
dir = RIGHT;
 117}
 118
 119void initEnemy(Enemy enemy[], int x, int y, int numEnemy)
 120{
for(int i = 0; i < numEnemy; i++)
{
  enemy[i].live = true;
  enemy[i].speedR = 2;
  enemy[i].speedL = -2;
  enemy[i].speed = 2;
  enemy[i].x = x;
  enemy[i].y = y;
  enemy[i].width = 29;
  enemy[i].height = 29;
}
 132
 133}
 134void drawEnemy(Enemy enemy[], ALLEGRO_BITMAP *image, int numEnemy)
 135{
for(int i = 0; i < numEnemy; i++)
{
  if(enemy[i].live)
  {
    al_draw_bitmap(image, enemy[i].x, enemy[i].y, 0);
  }
}
  
 144}
 145void updateEnemy(Enemy enemy[], int posX, int posX2, int numEnemy)
 146{
for(int i = 0; i < numEnemy; i++)
{
    if(enemy[i].live)
    {
      enemy[i].x += enemy[i].speed;
      if(enemy[i].x >= posX)
      {
        enemy[i].x = posX;
        enemy[i].speed = enemy[i].speedL;
      }
      if(enemy[i].x <= posX2)
      {
        enemy[i].x = posX2;
        enemy[i].speed = enemy[i].speedR;
      }
    }
}
 164
 165}    
 166bool collideArrow(Enemy enemy[], Arrow &arrow, bool eLive, bool aLive, int numEnemy)
 167{
for(int i = 0; i < numEnemy; i++)
{
  if((arrow.x > enemy[i].x + enemy[i].width) || (arrow.y > enemy[i].y + enemy[i].height) ||
  (enemy[i].x > arrow.x + arrow.height) || (enemy[i].y > arrow.y + arrow.height) && (enemy[i].live) && (arrow.live))
{
  return false;
}
return true;
}

 178}
 179
 180void initCoin(Coin &coin, int x, int y)
 181{
coin.width = 16;
coin.height = 16;
coin.live = true;
coin.x = x;
coin.y = y;
 187}
 188void drawCoin(Coin &coin, ALLEGRO_BITMAP *image)
 189{
float scale = 5;
float time_step = 0;
float time = 0;
time += time_step;
float offset_y = abs(sin(time)) * scale;
if(coin.live)
{
   if(image == NULL)
     al_draw_filled_circle(coin.x - 10, coin.y - 10, 20, al_map_rgb(255,0,255));
   else
   al_draw_bitmap(image, coin.x, coin.y - offset_y, 0);  
}
 202}
 203bool coinCollide(Coin &coin,Player &player, int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, bool live, int coinCount)
 204{
if((player.x > cX + cWidth) || (player.y > cY + cHeight) ||
  (cX > player.x + pWidth) || (cY > player.y + pHeight) && (coin.live))
{
  return false;
}
return true;
 211}
 212
 213void initArrow(Arrow &arrow)
 214{
  arrow.speed = 4.0;
  arrow.live = false;
  arrow.arrowCount = 10;  
  arrow.width = 16;
  arrow.height = 5;
  arrow.aVelX = 0; 
  arrow.aVelY = 0;
 222}
 223void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2)
 224{
  if(arrow.live && dir == RIGHT)
  {
    al_draw_bitmap(image, arrow.x, arrow.y, 0);
  }
  if(arrow.live && dir == LEFT)
  {
    al_draw_bitmap(image2, arrow.x, arrow.y, 0);
  }
  
 234}
 235void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot)
 236{
  if(!arrow.live)
  {
    --arrow.arrowCount;
    arrow.live = true;
    arrow.x = player.x + 17;
    arrow.y = player.y + 22;
    fired = true;
    al_play_sample(bowShot, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
    
  }

 248}
 249void updateArrow(Arrow &arrow)
 250{
  if(arrow.live && fired)
  {
    if(dir == RIGHT)
    {
      arrow.x += arrow.speed;
    }
    if(dir == LEFT)
    {
      arrow.x -= arrow.speed;
    }
      if(arrow.x >=  2000 - 10)
      {
        arrow.live = false;
      }
      if(arrow.x <= 0 + 3)
      {
        arrow.live = false;
      }
      else if(arrow.arrowCount <= 0)
      {
        fired = false;
      }
  
  }
 275}
 276
 277void initKey(Key &key)
 278{
key.x = 979;
key.y = 151;
key.width = 32;
key.height = 32;
key.live = true;
 284}
 285void drawKey(Key &key, ALLEGRO_BITMAP *image)
 286{
if(key.live)
{
  al_draw_bitmap(image, 979, 151, 0);
}
 291}
 292
 293bool collision(Player &player, int ex, int ey, int eWidth, int eHeight, int pWidth, int pHeight)
 294{
if((player.x > ex + eWidth - 10) || (player.y > ey + eHeight - 10) ||
  (ex > player.x + pWidth - 10) || (ey > player.y + pHeight - 10))
{
  return false;
}
return true;
 301}
 302
 303void cameraUpdate(float *cameraPosition, Player &player, float width, float height)
 304{
cameraPosition[0] = -(ScreenWidth / 2) + (player.x + width / 2);
cameraPosition[1] = -(ScreenHeight) + (player.y + height / 2);
 307
if(cameraPosition[0] < 0)
  cameraPosition[0] = 0;
if(cameraPosition[1] < 0)
  cameraPosition[1] = 0;
if(cameraPosition[0] > 3000 - ScreenWidth)
  cameraPosition[0] = 3000 - ScreenWidth;
 314
 315}

no-reply@allegro.cc (Schyfis) — Mon, 25 Feb 2013 00:54:14 +0000

DJLad16 said:

Haha, switching the two numbers around in update enemy got it working. I've been at that all day and all I needed to do was that... FML.

That's why you should always give your function parameters descriptive names, such as minimum_x and maximum_x! It will eliminate a lot of problems for you in the future if you remember to do this.

Quote:

And dizzy, I tried your suggestion with class arrays, but I couldn't get it to work.

Can you show us how you were doing it?

no-reply@allegro.cc (DJLad16) — Mon, 25 Feb 2013 01:02:28 +0000

I had it, but then undo'd it back to the original. And I've been programming and doing stuff for my game for quite some time now and I'm tired, so I'll give you a post tomorrow if I have the time Thanks for the helping me anyway