no-reply@allegro.cc (DJLad16) — Fri, 22 Feb 2013 01:57:52 +0000

I have an enemy in which I need to disappear when the arrow hits it, I've got the collision working (or so it should be), but when the arrow hits the enemy, the arrow disappears as I want it. However, the enemy doesn't - even though I've set it to false. The current way I'm doing is is not really efficient, I'm just giving the enemy -x, y coordinates so it will just be off screen. (I also don't like doing that because ist like a 'cheat' way of doing it, and also not really help power if I were to do it in a bigger game).
I've had to remove some of the code for size of the post error.

#SelectExpand
   1//Prototpyes
   2void initPlayer(Player &player);
   3
   4void initEnemy1(Enemy &enemy1);
   5void drawEnemy1(Enemy &enemy1, ALLEGRO_BITMAP *image);
   6void updateEnemy1(Enemy &enemy1);
   7bool collideArrow(Enemy &enemy1, Arrow &arrow);
   8
   9void initCoin(Coin &coin1);
  10void drawCoin(Coin &coin1, ALLEGRO_BITMAP *image);
  11bool coinCollide(Coin &coin1,Player &player ,int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, int coinCount);
  12
  13void initCoin2(Coin &coin2);
  14void drawCoin2(Coin &coin2, ALLEGRO_BITMAP *image);
  15bool coinCollide2(Coin &coin2,Player &player ,int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, int coinCount);
  16
  17void initArrow(Arrow &arrow);
  18void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2);
  19void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot);
  20void updateArrow(Arrow &arrow);
  21
  22bool collision(Player &player, int ex, int ey, int eWidth, int eHeight, int pWidth, int pHeight);
  23
  24void cameraUpdate(float *cameraPosition,Player &player, float width, float height);
  25
  26//Global Variables
  27enum direction {LEFT, RIGHT};
  28int dir = LEFT;
  29//int arrowCount = 10;
  30//const int NUM_ARROW = 10;
  31const int NUM_ENEMY = 10;
  32int groundHeight = 545;
  33bool fired = false;
  34bool coinLive = false;
  35bool left, right = false;
  36float cameraX, cameraY = 0;
  37const float gravity = 1;
  38
  39int main()
  40{
  41
Player player;
Enemy enemy1;
Coin coin1;
Coin coin2;
Arrow arrow;
bool done = false, active = false, draw = true;
bool jump = false;
int sourceX = 32, sourceY = 0;
int coinCount = 0;
const float FPS = 70.0;
float gameFPS = 0;
float jumpSpeed = 15.0;
float velX = 0, velY = 0;

float cameraPosition[2] = {0,0};
  57

  59
al_init_image_addon();
al_init_primitives_addon();
al_install_keyboard();
al_init_font_addon();
al_init_ttf_addon();
al_install_audio();
al_init_acodec_addon();
  67
initPlayer(player);
initEnemy1(enemy1);
initArrow(arrow);
initCoin(coin1);
initCoin2(coin2);
  73
al_start_timer(timer);
while(!done)
{
  ALLEGRO_EVENT event;
  al_wait_for_event(event_queue, &event);
  al_get_keyboard_state(&keystate);
    
  if(al_key_down(&keystate, ALLEGRO_KEY_ESCAPE))
  {
    done = true;
  }
  else if(event.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
  {
    done = true;
  }
  
  
  else if(event.type == ALLEGRO_EVENT_TIMER)
  {
    active = true;
    updateArrow(arrow);
    updateEnemy1(enemy1);
  96
    if(al_key_down(&keystate, ALLEGRO_KEY_D))
    {
      velX = player.speed;
      dir = RIGHT;
      
    }
    else if(al_key_down(&keystate, ALLEGRO_KEY_A))
    {
      velX = -player.speed;
      dir = LEFT;
    }
 108
    else 
    {
      velX = 0;
      active = false;
    }
    if(al_key_down(&keystate, ALLEGRO_KEY_W) && jump)
    {
      velY = -jumpSpeed;
      jump = false;
    }
    if(active)
    {
      sourceX += al_get_bitmap_width(character) / 3;
    }
    else 
    {
      sourceX = 32; 
    }
    if(sourceX >= al_get_bitmap_width(character))
    {
      sourceX = 0;
    }
      sourceY = dir;
        draw = true;
    if(!jump)
      velY += gravity;
    else
      velY = 0;
      player.x += velX;
      player.y += velY;
    
    jump = (player.y >= groundHeight);
 141
    if(jump)
    {
      player.y = groundHeight;
    }
 146
    cameraUpdate(cameraPosition, player, 32, 32);
    al_identity_transform(&camera);
    al_translate_transform(&camera, -cameraPosition[0], -cameraPosition[1]);
    al_use_transform(&camera);
 151
  }
  
  if(al_key_down(&keystate, ALLEGRO_KEY_SPACE))
  {
    fireArrow(arrow, player, bowShot);
  }
  
  if(coinCollide(coin1, player, coin1.x, coin1.y, coin1.width, coin1.height, 32, 32, coinCount))
  {
    coin1.live = false;
    ++coinCount;
    coin1.x = 0;
    coin1.y = 0;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(coinCollide2(coin2, player, coin2.x, coin2.y, coin2.width, coin1.height, 32, 32, coinCount))
  {
    coin2.live = false;
    ++coinCount;
    coin2.x = 0;
    coin2.y = 0;
    al_play_sample(coinCollect, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
  }
  if(collideArrow(enemy1, arrow))
  {
    enemy1.live = false;
    enemy1.x = -500;
    enemy1.y = -500;
    enemy1.speedR = 0;
    enemy1.speedL = 0;
    enemy1.speed = 0;      
    arrow.live = false;
  } 
  
if(draw && al_is_event_queue_empty(event_queue))
{
  draw = false;
  al_draw_bitmap(background2, 0, 0, 0);
  al_draw_bitmap_region(character, sourceX, sourceY * al_get_bitmap_height(character) / 2, 32, 32, player.x, player.y, 0);
  drawArrow(arrow, arrow_r, arrow_l);
  drawCoin(coin1, coin);
  drawCoin2(coin2, coin);
  drawEnemy1(enemy1, enemy);
  al_identity_transform(&identity);
  al_use_transform(&identity);
  al_draw_textf(numArrow, al_map_rgb(252,209, 22), 10, 10, 0, "Arrows: %i", arrow.arrowCount);
  al_draw_textf(numCoin, al_map_rgb(252, 209, 22), 10, 50, 0, "Coins: %i", coinCount);
  al_draw_textf(lives, al_map_rgb(252, 209, 22), 110, 10, 0, "Lives: %i", player.lives);
  //al_draw_textf(fps, al_map_rgb(252, 209, 22), 120, 10, 0, "FPS: %i", gameFPS);
  al_flip_display();
  al_clear_to_color(al_map_rgb(255, 255, 255));
 203
}
}
 206
al_destroy_bitmap(character);
al_destroy_bitmap(ground);
al_destroy_bitmap(coin);
al_destroy_bitmap(background2);
al_destroy_bitmap(arrow_l);
al_destroy_bitmap(arrow_r);
al_destroy_sample(coinCollect);
al_destroy_sample(bowShot);
al_destroy_sample(bgSong);
al_destroy_sample_instance(songInstance);
al_destroy_font(numArrow);
al_destroy_font(numCoin);
al_destroy_font(fps);
al_destroy_display(display);
al_destroy_event_queue(event_queue);
al_destroy_timer(timer);
return 0;
 224}
 225void initPlayer(Player &player)
 226{
player.x = 10;
player.y = 545;
player.ID = PLAYER;
player.lives = 3;
player.speed = 5;
player.score = 0;
dir = RIGHT;
 234}
 235
 236void initEnemy1(Enemy &enemy1)
 237{
enemy1.ID = ENEMY;
enemy1.live = false;
enemy1.speedR = 2;
enemy1.speedL = -2;
enemy1.speed = 2;
enemy1.x = 86;
enemy1.y = 391;
enemy1.width = 29;
enemy1.height = 29;
 247}
 248void drawEnemy1(Enemy &enemy1, ALLEGRO_BITMAP *image)
 249{
enemy1.live = true;
  if(enemy1.live)
  {
    al_draw_bitmap(image, enemy1.x, enemy1.y, 0);
  }
 255}
 256void updateEnemy1(Enemy &enemy1)
 257{
if(enemy1.live)
{
  enemy1.x += enemy1.speed;
    if(enemy1.x >= 238)
    {
      enemy1.x = 238;
      enemy1.speed = enemy1.speedL;
    }
    if(enemy1.x <= 78)
    {
      enemy1.x = 78;
      enemy1.speed = enemy1.speedR;
    }
}
 272}
 273bool collideArrow(Enemy &enemy1, Arrow &arrow)
 274{
if((arrow.x > enemy1.x + enemy1.width) || (arrow.y > enemy1.y + enemy1.height) ||
  (enemy1.x > arrow.x + arrow.height) || (enemy1.y > arrow.y + arrow.height))
{
  return false;
}
return true;
 281}
 282
 283void initCoin(Coin &coin1)
 284{
coin1.ID = COIN;
coin1.width = 16;
coin1.height = 16;
coin1.live = true;
coin1.x = 550;
coin1.y = 480;
 291}
 292void drawCoin(Coin &coin1, ALLEGRO_BITMAP *image)
 293{
if(coin1.live)
{
   if(image == NULL)
     al_draw_filled_circle(coin1.x - 10, coin1.y - 10, 20, al_map_rgb(255,0,255));
   else
     al_draw_bitmap(image, coin1.x, coin1.y, 0);  
}
 301}
 302void initCoin2(Coin &coin2)
 303{
coin2.ID = COIN;
coin2.width = 16;
coin2.height = 16;
coin2.live = true;
coin2.x = 120;
coin2.y = 395;
 310}
 311void drawCoin2(Coin &coin2, ALLEGRO_BITMAP *image)
 312{
if(coin2.live)
{
   if(image == NULL)
     al_draw_filled_circle(coin2.x - 10, coin2.y - 10, 20, al_map_rgb(255,0,255));
   else
     al_draw_bitmap(image, coin2.x, coin2.y, 0);  
}
 320}
 321bool coinCollide(Coin &coin1,Player &player, int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, int coinCount)
 322{
if((player.x > cX + cWidth) || (player.y > cY + cHeight) ||
  (cX > player.x + pWidth) || (cY > player.y + pHeight) && (coin1.live))
{
  return false;
}
return true;
 329}
 330bool coinCollide2(Coin &coin2,Player &player, int cX, int cY, int cWidth, int cHeight, int pWidth, int pHeight, int coinCount)
 331{
if((player.x > cX + cWidth) || (player.y > cY + cHeight) ||
  (cX > player.x + pWidth) || (cY > player.y + pHeight) && (coin2.live))
{
  return false;
}
return true;
 338}
 339
 340void initArrow(Arrow &arrow)
 341{
  arrow.ID = ARROW;
  arrow.speed = 4.0;
  arrow.live = false;
  arrow.arrowCount = 10;  
  arrow.width = 16;
  arrow.height = 5;
  arrow.aVelX = 0; 
  arrow.aVelY = 0;
 350}
 351void drawArrow(Arrow &arrow, ALLEGRO_BITMAP *image, ALLEGRO_BITMAP *image2)
 352{
  if(arrow.live && dir == RIGHT)
  {
    al_draw_bitmap(image, arrow.x, arrow.y, 0);
  }
  if(arrow.live && dir == LEFT)
  {
    al_draw_bitmap(image2, arrow.x, arrow.y, 0);
  }
  
 362}
 363void fireArrow(Arrow &arrow, Player &player, ALLEGRO_SAMPLE *bowShot)
 364{
  if(!arrow.live)
  {
    --arrow.arrowCount;
    arrow.live = true;
    arrow.x = player.x + 17;
    arrow.y = player.y + 22;
    fired = true;
    al_play_sample(bowShot, 1.0, 0.0, 1.0, ALLEGRO_PLAYMODE_ONCE, 0);
    
  }

 376}
 377void updateArrow(Arrow &arrow)
 378{
  if(arrow.live && fired)
  {
    if(dir == RIGHT)
    {
      arrow.x += arrow.speed;
    }
    else if(dir == LEFT)
    {
      arrow.x -= arrow.speed;
    }
      if(arrow.x >=  2000 - 10)
      {
        arrow.live = false;
      }
      if(arrow.x <= 0 + 10)
      {
        arrow.live = false;
      }
      else if(arrow.arrowCount <= 0)
      {
        fired = false;
      }
  
  }
 403}
 404
 405bool collision(Player &player, int ex, int ey, int eWidth, int eHeight, int pWidth, int pHeight)
 406{
if((player.x > ex + eWidth - 10) || (player.y > ey + eHeight - 10) ||
  (ex > player.x + pWidth - 10) || (ey > player.y + pHeight - 10))
{
  return false;
}
return true;
 413}
 414
 415void cameraUpdate(float *cameraPosition, Player &player, float width, float height)
 416{
cameraPosition[0] = -(ScreenWidth / 2) + (player.x + width / 2);
cameraPosition[1] = -(ScreenHeight) + (player.y + height / 2);
 419
if(cameraPosition[0] < 0)
  cameraPosition[0] = 0;
if(cameraPosition[1] < 0)
  cameraPosition[1] = 0;
if(cameraPosition[0] > 2000 - ScreenWidth)
  cameraPosition[0] = 2000 - ScreenWidth;
 426
 427}

no-reply@allegro.cc (beoran) — Fri, 22 Feb 2013 02:00:55 +0000

void drawEnemy1(Enemy &enemy1, ALLEGRO_BITMAP *image)
{
  enemy1.live = true;

You're setting it live on every redraw...

no-reply@allegro.cc (Schyfis) — Fri, 22 Feb 2013 02:05:23 +0000

In drawEnemy1, you set enemy1.live = true. Then when updateEnemy1 is called, it sets the enemy's position again.

Edit: I missed a post. :/

no-reply@allegro.cc (Jeff Bernard) — Fri, 22 Feb 2013 08:56:25 +0000

Saw this thread in Recent Threads. Was disappointed that it was a programming question.

How to make my enemy disappear? (Killed)