al_load_bitmap and unicode characters in filename

no-reply@allegro.cc (kovarex) — Tue, 19 Feb 2013 19:10:35 +0000

Hello,

when I try to load images with unicode characters in the file name, it fails.
I did little digging, and found out, that the code should handle wide char conversion for the file name actually breaks it.

#SelectExpand
  1static void *file_stdio_fopen(const char *path, const char *mode)
  2{
  3   FILE *fp;
  4
  5#ifdef ALLEGRO_WINDOWS
  6   {
  7      wchar_t *wpath = _al_win_utf16(path);
  8      wchar_t *wmode = _al_win_utf16(mode);
  9      fp = _wfopen(wpath, wmode);
 10      al_free(wpath);
 11      al_free(wmode);
 12   }
 13#else
 14   fp = fopen(path, mode);
 15#endif
 16
 17   if (!fp) {
 18      al_set_errno(errno);
 19      return NULL;
 20   }
 21
 22   return fp;
 23}

When I changed the ifdef ALLEGRO_WINDOWS to #if 0 (sing the non-windows variant), it started working, and I could load those files.

I'm probably doing something the wrong way, but not sure what is it, I'm no expert of wide string/utf 8.

no-reply@allegro.cc (Peter Wang) — Tue, 19 Feb 2013 19:35:54 +0000

Then you're probably not providing a UTF-8 path. Sample code?

no-reply@allegro.cc (kovarex) — Tue, 19 Feb 2013 20:21:21 +0000

The part of the filename that contains invalid characteres (User name on windows, while accessing the User//AppData/Roaming ...

#SelectExpand
  1boost::filesystem::path Paths::getSystemWriteData()
  2{
TCHAR szPath[MAX_PATH];
  4
if (SUCCEEDED(SHGetFolderPath(NULL,
                              CSIDL_APPDATA | CSIDL_FLAG_CREATE,
                              NULL,
                              0,
                              szPath)))
{
  boost::filesystem::path result = boost::filesystem::path(szPath) / "Factorio";
  boost::filesystem::create_directories(result);
  return result;
}
else
  throw std::runtime_error("Couldn't get application data directory");
 17}

Later I just make string out of the path (path / "preview image path").string() and send it to the allegro.

You can see, that boost has no problem with creating the directory that contains the unicode character.

no-reply@allegro.cc (Audric) — Tue, 19 Feb 2013 21:02:40 +0000

.string() returns a std::string, you still need to convert it to a sequence of UTF-8 to pass it to al_load_bitmap()

no-reply@allegro.cc (Thomas Fjellstrom) — Tue, 19 Feb 2013 21:05:29 +0000

Also have to make sure its in UTF-8, rather than the UTF-16 that windows returns.