<?xml version="1.0"?>
<rss version="2.0">
	<channel>
		<title>fps problem with al_draw_bitmap</title>
		<link>http://www.allegro.cc/forums/view/610016</link>
		<description>Allegro.cc Forum Thread</description>
		<webMaster>matthew@allegro.cc (Matthew Leverton)</webMaster>
		<lastBuildDate>Sat, 14 Apr 2012 21:55:09 +0000</lastBuildDate>
	</channel>
	<item>
		<description><![CDATA[<div class="mockup v2"><p>Hi</p><p>Before I start telling you about my problem, I&#39;d like to point out that I&#39;m pretty new to C++ in general. All I know is from youtube tutorials so there is a few things that I still don&#39;t have a complete understanding of yet.</p><p>Now with that aside, I have a problem with al_draw_bitmap function causing a huge FPS drop on my game. I&#39;ve got a timer limiting my game to 60 FPS, but the function it all the way down to 25 - and after running for some time it drops down to 9-10 and a bit later all the way down to 6, so it&#39;s definitely a issue I need to get solved somehow.</p><p>Here&#39;s all the code I believe is relevant - if you need to see more just ask and I&#39;ll post that too</p><p>First of we have the constructor of the class that contains the function that draws the bitmaps. This is where I load the images in.<br />This is only fired once so the problem is not caused by the images being loaded in multiple times (the cout acts as proof of that ).</p><p>I&#39;ve also got a deconstruct which destroy the loaded files, but that&#39;s not important for this.</p><div class="source-code"><div class="toolbar"><span class="button numbers"><b>#</b></span><span class="button select">Select</span><span class="button expand">Expand</span></div><div class="inner"><span class="number"> 1</span>objects::objects<span class="k2">(</span><span class="k2">)</span>
<span class="number"> 2</span><span class="k2">:</span>   skyHeight<span class="k2">(</span> <span class="n">500</span> <span class="k2">)</span>
<span class="number"> 3</span><span class="k2">{</span>
<span class="number"> 4</span>    cout <span class="k3">&lt;</span><span class="k3">&lt;</span> <span class="s">"Objects object created"</span> <span class="k3">&lt;</span><span class="k3">&lt;</span> endl<span class="k2">;</span>
<span class="number"> 5</span>    grassBit <span class="k3">=</span> <a href="http://www.allegro.cc/manual/al_load_bitmap"><span class="a">al_load_bitmap</span></a><span class="k2">(</span> <span class="s">"grass.png"</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 6</span>    objectBit <span class="k3">=</span> <a href="http://www.allegro.cc/manual/al_load_bitmap"><span class="a">al_load_bitmap</span></a><span class="k2">(</span> <span class="s">"object.png"</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 7</span><span class="k2">}</span>
</div></div><p>

Here the function I where the problem lies with - I&#39;ve called it DrawGrass</p><div class="source-code"><div class="toolbar"><span class="button numbers"><b>#</b></span><span class="button select">Select</span><span class="button expand">Expand</span></div><div class="inner"><span class="number">  8</span><span class="k1">void</span> objects::DrawGrass<span class="k2">(</span> <span class="k1">int</span> screenW, <span class="k1">int</span> camX, <span class="k1">int</span> camY <span class="k2">)</span><span class="k2">{</span>
<span class="number">  9</span>    <span class="k1">float</span> side <span class="k3">=</span> <span class="n">50</span>.<span class="n">0</span><span class="k2">;</span>
<span class="number"> 10</span>    <span class="k1">int</span> posY <span class="k3">=</span> skyHeight <span class="k3">-</span> camY<span class="k2">;</span>
<span class="number"> 11</span>
<span class="number"> 12</span>    <span class="k1">float</span> startX <span class="k3">=</span> camX <span class="k3">/</span> side<span class="k2">;</span>
<span class="number"> 13</span>    <span class="k1">int</span> roundX <span class="k3">=</span> startX<span class="k2">;</span>
<span class="number"> 14</span>    startX <span class="k3">=</span> <span class="k2">(</span> startX <span class="k3">-</span> roundX <span class="k2">)</span> <span class="k3">*</span> side<span class="k2">;</span>
<span class="number"> 15</span>    <span class="k1">int</span> posX <span class="k3">=</span> <span class="n">0</span> <span class="k3">-</span> startX<span class="k2">;</span>
<span class="number"> 16</span>
<span class="number"> 17</span>    <span class="k1">if</span><span class="k2">(</span> posY <span class="k3">&gt;</span> <span class="n">0</span> <span class="k3">-</span> side <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 18</span>        <span class="k1">while</span><span class="k2">(</span> posX <span class="k3">&lt;</span> screenW <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 19</span>            <span class="c">//al_draw_filled_rectangle( posX, posY, posX + side, posY + side, al_map_rgb( 0,255,0 ) );</span>
<span class="number"> 20</span>            <a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a><span class="k2">(</span> grassBit, posX, posY, ALLEGRO_VIDEO_BITMAP <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 21</span>            posX <span class="k3">+</span><span class="k3">=</span> <span class="n">50</span><span class="k2">;</span>
<span class="number"> 22</span>        <span class="k2">}</span>
<span class="number"> 23</span>    <span class="k2">}</span>
<span class="number"> 24</span><span class="k2">}</span>
</div></div><p>

Basicly it draws the bitmap from left to right using a while loop based on input of screenW, camX and camY making sure not to draw anymore than what is needed.</p><p>You can also see that I&#39;ve commented out an al_draw_filled_rectangle. It&#39;s something I used for testing and it worked just fine without any fps drop what so ever.</p><p>Here&#39;s where I call the function</p><div class="source-code"><div class="toolbar"><span class="button numbers"><b>#</b></span><span class="button select">Select</span><span class="button expand">Expand</span></div><div class="inner"><span class="number"> 25</span><span class="k1">void</span> game::ComposeFrame<span class="k2">(</span> <a href="http://www.allegro.cc/manual/ALLEGRO_DISPLAY"><span class="a">ALLEGRO_DISPLAY</span></a> <span class="k3">*</span>display <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 26</span>    <span class="k1">if</span><span class="k2">(</span> gameState <span class="k3">=</span><span class="k3">=</span> <a href="http://www.allegro.cc/manual/MENU"><span class="a">MENU</span></a> <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 27</span>        mob.DrawMenu<span class="k2">(</span><span class="k2">)</span><span class="k2">;</span>
<span class="number"> 28</span>        mob.DrawMenuText<span class="k2">(</span><span class="k2">)</span><span class="k2">;</span>
<span class="number"> 29</span>    <span class="k2">}</span>
<span class="number"> 30</span>    <span class="k1">else</span> <span class="k1">if</span><span class="k2">(</span> gameState <span class="k3">=</span><span class="k3">=</span> GAME <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 31</span>        <span class="c">/* Game drawing *************************************************************************************************</span>
<span class="number"> 32</span><span class="c">        ************************************************************************************************************** */</span>
<span class="number"> 33</span>
<span class="number"> 34</span>        <span class="c">// Background drawing</span>
<span class="number"> 35</span>        <a href="http://www.allegro.cc/manual/al_draw_filled_rectangle"><span class="a">al_draw_filled_rectangle</span></a><span class="k2">(</span> <span class="n">0</span>, <span class="n">0</span>, screenWidth, screenHeight, <a href="http://www.allegro.cc/manual/al_map_rgb"><span class="a">al_map_rgb</span></a><span class="k2">(</span> <span class="n">50</span>, <span class="n">50</span>, <span class="n">50</span> <span class="k2">)</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 36</span>        obj.DrawSky<span class="k2">(</span> screenWidth, screenHeight, cam.GetCamX<span class="k2">(</span><span class="k2">)</span>, cam.GetCamY<span class="k2">(</span><span class="k2">)</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 37</span>
<span class="number"> 38</span>        <span class="c">// Game object drawing</span>
<span class="number"> 39</span>        obj.DrawObject<span class="k2">(</span> screenWidth, screenHeight, cam.GetCamX<span class="k2">(</span><span class="k2">)</span>, cam.GetCamY<span class="k2">(</span><span class="k2">)</span>, <span class="n">7450</span>, <span class="n">400</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 40</span>        obj.DrawGrass<span class="k2">(</span> screenWidth, cam.GetCamX<span class="k2">(</span><span class="k2">)</span>, cam.GetCamY<span class="k2">(</span><span class="k2">)</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 41</span>
<span class="number"> 42</span>        <span class="c">// Ingame menu bar drawing</span>
<span class="number"> 43</span>        mob.DrawGameMenu<span class="k2">(</span><span class="k2">)</span><span class="k2">;</span>
<span class="number"> 44</span>
<span class="number"> 45</span>        <span class="c">/* **************************************************************************************************************</span>
<span class="number"> 46</span><span class="c">        ************************************************************************************************************** */</span>
<span class="number"> 47</span>
<span class="number"> 48</span>        <span class="k1">if</span><span class="k2">(</span> <a href="http://www.delorie.com/djgpp/doc/libc/libc_613.html" target="_blank">pause</a> <span class="k2">)</span><span class="k2">{</span>
<span class="number"> 49</span>            <span class="c">/* Pause menu drawing ***************************************************************************************</span>
<span class="number"> 50</span><span class="c">            ********************************************************************************************************** */</span>
<span class="number"> 51</span>
<span class="number"> 52</span>            <a href="http://www.allegro.cc/manual/al_draw_filled_rectangle"><span class="a">al_draw_filled_rectangle</span></a><span class="k2">(</span> <span class="n">0</span>, <span class="n">0</span>, screenWidth, screenHeight, <a href="http://www.allegro.cc/manual/al_map_rgba"><span class="a">al_map_rgba</span></a><span class="k2">(</span> <span class="n">0</span>,<span class="n">0</span>,<span class="n">0</span>,<span class="n">50</span> <span class="k2">)</span> <span class="k2">)</span><span class="k2">;</span>
<span class="number"> 53</span>            mob.DrawMenu<span class="k2">(</span><span class="k2">)</span><span class="k2">;</span>
<span class="number"> 54</span>            mob.DrawMenuText<span class="k2">(</span><span class="k2">)</span><span class="k2">;</span>
<span class="number"> 55</span>
<span class="number"> 56</span>            <span class="c">/* **********************************************************************************************************</span>
<span class="number"> 57</span><span class="c">            ********************************************************************************************************** */</span>
<span class="number"> 58</span>        <span class="k2">}</span>
<span class="number"> 59</span>    <span class="k2">}</span>
<span class="number"> 60</span><span class="k2">}</span>
</div></div><p>

The function at question get called on line 40.</p><p>Here&#39;s an image of what it looks like just to give you a better idea of what is going on.</p><p><span class="remote-thumbnail"><span class="json">{"name":"digginholeswip.jpg","src":"\/\/djungxnpq2nug.cloudfront.net\/image\/cache\/1\/c\/1c01c75bf89b2b08a2b870db4f691805.jpg","w":815,"h":638,"tn":"\/\/djungxnpq2nug.cloudfront.net\/image\/cache\/1\/c\/1c01c75bf89b2b08a2b870db4f691805"}</span><img src="http://www.allegro.cc//djungxnpq2nug.cloudfront.net/image/cache/1/c/1c01c75bf89b2b08a2b870db4f691805-240.jpg" alt="digginholeswip.jpg" width="240" height="187" /></span></p><p>Should note that as soon as the grass strip gets out of the screen the FPS goes right back up to FPS until it comes back in.</p><p>I have tried a few things on fixing this. One of them was making my entire draw routine draw to a bitmap object which then got drawn to the backbuffer, but never managed to that working.</p><p>I&#39;ve also tried using al_set_new_bitmap_flags( ALLEGRO_VIDEO_BITMAP ), which didn&#39;t help, but I&#39;m not sure I used it right either. What I did was adding that to the constructor before I loaded the bitmaps and then added ALLEGRO_VIDEO_BITMAP to the flag in the DrawGrass function</p><p>Hope you can help me with this. As I said if you need to see more of the code I&#39;ll get it posted asap.</p><p>Edad Tace
</p></div>]]>
		</description>
		<author>no-reply@allegro.cc (EdadTace)</author>
		<pubDate>Sat, 14 Apr 2012 20:51:46 +0000</pubDate>
	</item>
	<item>
		<description><![CDATA[<div class="mockup v2"><p>Three things.</p><p>1. <span class="source-code">ALLEGRO_VIDEO_BITMAP</span> does not go here, look in the documentation of the <span class="source-code"><a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a></span> function for what goes into that argument:<br /><span class="source-code"><a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a><span class="k2">(</span> grassBit, posX, posY, ALLEGRO_VIDEO_BITMAP <span class="k2">)</span><span class="k2">;</span></span></p><p>2. Try using deferred bitmap drawing like so:
</p><div class="source-code snippet"><div class="inner"><pre><div class="highlight">        <a href="http://www.allegro.cc/manual/al_hold_bitmap_drawing"><span class="a">al_hold_bitmap_drawing</span></a><span class="k2">(</span><span class="k1">true</span><span class="k2">)</span><span class="k2">;</span></div>
        <span class="k1">while</span><span class="k2">(</span> posX <span class="k3">&lt;</span> screenW <span class="k2">)</span><span class="k2">{</span>
            <span class="c">//al_draw_filled_rectangle( posX, posY, posX + side, posY + side, al_map_rgb( 0,255,0 ) );</span>
            <a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a><span class="k2">(</span> grassBit, posX, posY, ALLEGRO_VIDEO_BITMAP <span class="k2">)</span><span class="k2">;</span>
            posX <span class="k3">+</span><span class="k3">=</span> <span class="n">50</span><span class="k2">;</span>
        <span class="k2">}</span>
<div class="highlight">        <a href="http://www.allegro.cc/manual/al_hold_bitmap_drawing"><span class="a">al_hold_bitmap_drawing</span></a><span class="k2">(</span><span class="k1">false</span><span class="k2">)</span><span class="k2">;</span></div>
</pre></div></div><p>

3. Make sure you load your bitmaps <i>after</i> the display is created. I&#39;m betting that this is in fact the problem with your code.
</p></div>]]>
		</description>
		<author>no-reply@allegro.cc (SiegeLord)</author>
		<pubDate>Sat, 14 Apr 2012 21:25:21 +0000</pubDate>
	</item>
	<item>
		<description><![CDATA[<div class="mockup v2"><div class="quote_container"><div class="title"><a href="http://www.allegro.cc/forums/thread/610016/952473#target">EdadTace</a> said:</div><div class="quote"><p>
</p><div class="source-code snippet"><div class="inner"><pre>            <a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a><span class="k2">(</span> grassBit, posX, posY, ALLEGRO_VIDEO_BITMAP <span class="k2">)</span><span class="k2">;</span>
</pre></div></div><p>
</p></div></div><p>
The fourth parameter passed to <span class="source-code"><a href="http://www.allegro.cc/manual/al_draw_bitmap"><span class="a">al_draw_bitmap</span></a></span> is supposed to be zero, or a combination of ALLEGRO_FLIP_HORIZONTAL and/or ALLEGRO_FLIP_VERTICAL. So passing ALLEGRO_VIDEO_BITMAP makes no sense here.</p><p>Check what kind of bitmap the grass is by using <span class="source-code"><a href="http://www.allegro.cc/manual/al_get_bitmap_flags"><span class="a">al_get_bitmap_flags</span></a></span>. Make sure it is actually a video bitmap.
</p></div>]]>
		</description>
		<author>no-reply@allegro.cc (Edgar Reynaldo)</author>
		<pubDate>Sat, 14 Apr 2012 21:28:21 +0000</pubDate>
	</item>
	<item>
		<description><![CDATA[<div class="mockup v2"><p>thanks a lot for your replies</p><p>SiegeLord you was complete right in that it was caused by the bitmaps being loaded before I created the display. I havn&#39;t tried the deferred bitmap drawing yet, but I&#39;ll definitely check it out</p><p>about the ALLEGRO_VIDEO_BITMAP, I kinda figure it wasn&#39;t right, but again I had wasn&#39;t sure on how I was suppose to use it, so I just tried something - actually thought that I set it back to 0, but apparently not.</p><p>Edgar Reynaldo definitely try using that al_get_bitmap_flags and make sure they are video bitmaps</p><p>and again thanks you so much for your help - it have helped me bigtime <img src="http://www.allegro.cc/forums/smileys/grin.gif" alt=";D" />
</p></div>]]>
		</description>
		<author>no-reply@allegro.cc (EdadTace)</author>
		<pubDate>Sat, 14 Apr 2012 21:55:09 +0000</pubDate>
	</item>
</rss>
