Proposed fix for D3D TTF caching issue (Patch Included)

no-reply@allegro.cc (jmasterx) — Wed, 15 Feb 2012 03:15:59 +0000

See this thread for more information:
http://www.allegro.cc/forums/thread/609404/

This patch fixes this issue by unlocking the glyph page before getting the width or dimension of the Glyph.

Trent would like Peter Wang to have a look at this patch since he optimized the TTF Addon.

Thanks

no-reply@allegro.cc (Peter Wang) — Wed, 15 Feb 2012 04:47:56 +0000

Can you try this patch? It moves the unlocks out of the loop.

no-reply@allegro.cc (jmasterx) — Wed, 15 Feb 2012 04:59:51 +0000

With the unlock moved out of the loop, it works just fine

no-reply@allegro.cc (Peter Wang) — Wed, 15 Feb 2012 05:06:13 +0000

Eh, I made a patch and you didn't use it. Then you quoted a function definition but left out the function name...

Anyway, enough whining from me. Thanks for tracking down this bug

no-reply@allegro.cc (jmasterx) — Wed, 15 Feb 2012 05:08:35 +0000

The patch you posted seemed to be byte for byte the same as mine, so I figured it was faster to just try the change manually.

no-reply@allegro.cc (Peter Wang) — Wed, 15 Feb 2012 05:18:22 +0000

Mine had unlocks in two functions, like your first patch. I wasn't sure if you tested them both.

Btw, the reason I bring this stuff up is to smooth over the contribution process. Your name shows up a few times in the change log now. We can expect more from you in the future

no-reply@allegro.cc (jmasterx) — Wed, 15 Feb 2012 05:35:02 +0000

Sorry for not clarifying that I had tested both functions. I'll make a note of not omitting these things in the future