Physfs problem (cont'd)

no-reply@allegro.cc (xtheunknown0) — Mon, 19 Dec 2011 14:42:35 +0000

Hello,

Continuing from http://www.allegro.cc/forums/thread/609005,
I've added

   al_set_physfs_file_interface();

   ALLEGRO_FILE *file;
   if (!(file = al_fopen("02.gif", "r"))) {
      al_draw_textf(font, al_map_rgb(255, 255, 255), 250, 350, 0, "fopen: Error loading gif");
      al_flip_display();
      al_rest(4.0);
   }

before the start of my last post on the old thread. This new code works, but again, I can't load the gif. Any suggestions, please?

TIA,
xtheunknown0

no-reply@allegro.cc (Edgar Reynaldo) — Mon, 19 Dec 2011 15:03:44 +0000

Show your full code again.

no-reply@allegro.cc (xtheunknown0) — Sun, 25 Dec 2011 05:22:40 +0000

#SelectExpand
   1#include 
   2#include 
   3#include 
   4#include 
   5#include 
   6#include 
   7#include 
   8#include 
   9
  10static void show_image(ALLEGRO_BITMAP *bmp)/*{{{*/
  11{
 ALLEGRO_EVENT_QUEUE *queue;
 ALLEGRO_EVENT event;
  14
 queue = al_create_event_queue();
 al_register_event_source(queue, al_get_keyboard_event_source());
  17
 while (true) {
    al_draw_bitmap(bmp, 0, 0, 0);
    al_flip_display();
    al_wait_for_event(queue, &event);
    if (event.type == ALLEGRO_EVENT_KEY_DOWN
          && event.keyboard.keycode == ALLEGRO_KEY_ESCAPE) {
       break;
    }
 }
  27
 al_destroy_event_queue(queue);
  29}/*}}}*/
  30
  31int main(int argc, const char *argv[])
  32{
 ALLEGRO_DISPLAY *display;
 ALLEGRO_BITMAP *bmp;
 ALLEGRO_FS_ENTRY *entry;
 int i;
  37
 if (!al_init())
    return 1;
 al_init_primitives_addon();
 al_init_font_addon();
 al_init_ttf_addon();
  43
 display = al_create_display(640, 480);
 if (!display) {
    return 1;
 }
  48
 al_init_image_addon();
  50
 ALLEGRO_PATH *path = al_get_standard_path(ALLEGRO_RESOURCES_PATH);
  52
 al_append_path_component(path, "resources");
 al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 ALLEGRO_FONT *font = al_load_ttf_font("DejaVuSans.ttf", 12, 0); 
 if (!font) {
  al_draw_textf(font, al_map_rgb(255, 255, 255), 50, 1, 0, "Error loading font.\n");
    al_rest(4.0);
  return 1;
 }   
  61
  62
  63
 al_remove_path_component(path, -1);
 al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 al_draw_textf(font, al_map_rgb(255, 255, 255), 200, 200, 0, "%s", al_path_cstr(path, '/'));
 /* Set up PhysicsFS. */
 if (!PHYSFS_init(argv[0])) {
  al_draw_textf(font, al_map_rgb(255, 255, 255), 50, 1, 0, "Error initialising physicsfs");
    al_rest(4.0);
    return 1;
}
  73
 // This creates a ~/.allegro directory, which is very annoying to say the/*{{{*/
 // least - and no need for it in this example.
 //  if (!PHYSFS_setSaneConfig("allegro", "ex_physfs", NULL, 0, 0))
 //     return 1;/*}}}*/
 if (!PHYSFS_addToSearchPath("./data/ex_physfs.zip", 1)) {
  al_draw_textf(font, al_map_rgb(255, 255, 255), 50, 50, 0, "Error adding to search path.");
    al_flip_display();
    al_rest(4.0);
    return 1;
}
  84
 al_set_physfs_file_interface();
  86
 ALLEGRO_FILE *file;
 if (!(file = al_fopen("02.gif", "r"))) {
    al_draw_textf(font, al_map_rgb(255, 255, 255), 250, 350, 0, "fopen: Error loading gif");
    al_flip_display();
    al_rest(4.0);
 }
  93
 bmp = al_load_bitmap_f(file, ".gif");
 if (bmp) {
    show_image(bmp);
    al_rest(4.0);
    al_destroy_bitmap(bmp);
 }
 else {
  al_draw_textf(font, al_map_rgb(255, 255, 255), 50, 350, 0, "Error loading gif");
    al_flip_display();
    al_rest(4.0);
 }
 105
 PHYSFS_deinit();
 al_destroy_path(path);
 return 0;
 109}

no-reply@allegro.cc (Edgar Reynaldo) — Sun, 25 Dec 2011 11:20:49 +0000

And what does that code print out?

I made a simplified test case :

#SelectExpand
  1
  2#include 
  3#include 
  4#include 
  5
  6#include 
  7
  8#include 
  9using std::cout;
 10using std::endl;
 11
 12
 13int main(int argc, const char *argv[])
 14{
 15   ALLEGRO_DISPLAY *display;
 16   ALLEGRO_BITMAP *bmp;
 17//   ALLEGRO_FS_ENTRY *entry;
 18//   int i;
 19
 20   if (!al_init()) {
 21      cout << "Failed to initialize allegro 5." << endl;
 22      return 1;
 23   }
 24
 25   display = al_create_display(640, 480);
 26   if (!display) {
 27      cout << "Failed to create display." << endl;
 28      return 1;
 29   }
 30
 31   al_init_image_addon();
 32
 33   ALLEGRO_PATH *path = al_get_standard_path(ALLEGRO_RESOURCES_PATH);
 34   al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 35   cout << "Current working directory is " << al_get_current_directory() << endl;
 36   al_destroy_path(path);
 37
 38   if (!PHYSFS_init(argv[0])) {
 39      cout << "Failed to initialize PhysFS." << endl;
 40      return 1;
 41  }
 42
 43   if (!PHYSFS_addToSearchPath("./data/test.zip", 1)) {
 44      cout << "Error adding ./data/test.zip to search path." << endl;
 45      return 1;
 46  }
 47
 48   const char* file_name = "test.gif";
 49   al_set_physfs_file_interface();
 50
 51   ALLEGRO_FILE *file;
 52   if (!(file = al_fopen(file_name, "r"))) {
 53      cout << "Could not open " << file_name << " for reading." << endl;
 54      return 1;
 55   }
 56   else {
 57      cout << "Opened file " << file_name << " for reading." << endl;
 58   }
 59   
 60   bmp = al_load_bitmap_f(file, ".gif");
 61   if (bmp) {
 62      cout << "Loaded " << file_name << " using al_load_bitmap_f." << endl;
 63      al_clear_to_color(al_map_rgba(0,0,0,0));
 64      al_draw_bitmap(bmp , 0 , 0 , 0);
 65      al_flip_display();
 66      al_rest(5.0);
 67      al_destroy_bitmap(bmp);
 68   }
 69   else {
 70      cout << "Failed to load " << file_name << " from ALLEGRO_FILE* using al_load_bitmap_f." << endl;
 71   }
 72   al_fclose(file);
 73
 74   PHYSFS_deinit();
 75   return 0;
 76}

And here's a 7-zip of the source, exe, dlls, and data/test.zip file.

The gif in the zip file doesn't display properly, but if I do the exact same thing with a png instead, then it displays perfectly.

I think your gif is bad. Try loading it regularly (not using Physfs) and see if it is still NULL.

no-reply@allegro.cc (xtheunknown0) — Tue, 27 Dec 2011 09:38:26 +0000

Well I've tried to load a png file instead. I got this from http://images2.wikia.nocookie.net/__cb20090331234637/uncyclopedia/images/8/80/Smiley.png

Here, I get a blank screen.

#SelectExpand
  1#include 
  2#include 
  3#include 
  4#include 
  5#include 
  6#include 
  7#include 
  8#include 
  9
 10int main(int argc, const char *argv[])
 11{
 12   ALLEGRO_DISPLAY *display;
 13   ALLEGRO_BITMAP *bmp;
 14   ALLEGRO_FS_ENTRY *entry;
 15   int i;
 16
 17   if (!al_init())
 18      return 1;
 19   al_init_primitives_addon();
 20   al_init_font_addon();
 21   al_init_ttf_addon();
 22
 23   display = al_create_display(640, 480);
 24   if (!display) {
 25      return 1;
 26   }
 27
 28   al_init_image_addon();
 29
 30   ALLEGRO_PATH *path = al_get_standard_path(ALLEGRO_RESOURCES_PATH);
 31
 32   al_append_path_component(path, "resources");
 33   al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 34   ALLEGRO_FONT *font = al_load_ttf_font("DejaVuSans.ttf", 12, 0); 
 35   if (!font) {
 36    al_draw_textf(font, al_map_rgb(255, 255, 255), 50, 1, 0, "Error loading font.\n");
 37      al_rest(4.0);
 38    return 1;
 39   }   
 40
 41   al_remove_path_component(path, -1);
 42   al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 43   ALLEGRO_FILE *file;
 44   al_load_bitmap("./data/Smiley.png");
 45   al_rest(4.0);
 46   al_draw_textf(font, al_map_rgb(255, 255, 255), 200, 200, 0, "%s", al_path_cstr(path, '/'));
 47   al_destroy_path(path);
 48
 49   /* close_log(false); */
 50   return 0;
 51}

A screenshot of the output from the previous post is attached.

no-reply@allegro.cc (Edgar Reynaldo) — Tue, 27 Dec 2011 10:27:11 +0000

You get a blank screen because you never flipped the display. Load the png, make sure it gave you a valid ALLGRO_BITMAP*, then add it to a zip file and try again.

Like I said, your gif is probably corrupt or invalid. Try loading it with al_load_bitmap instead, and see if it works.

no-reply@allegro.cc (Arthur Kalliokoski) — Tue, 27 Dec 2011 10:28:40 +0000

IIRC Matt explained in another thread that Allegro still doesn't support GIF, even though the patent expired years ago.

no-reply@allegro.cc (Edgar Reynaldo) — Tue, 27 Dec 2011 10:31:49 +0000

I got a valid pointer from al_load_bitmap_f when loading a gif... It just didn't display like I thought it would...

no-reply@allegro.cc (Matthew Leverton) — Tue, 27 Dec 2011 10:36:13 +0000

In A5, Only BMP, PCX, and TGA are guaranteed to be supported. Support for JPEG and PNG will probably have been enabled.

OS X and Windows will support GIF (the first frame) if the OS-native image loading libraries are being used.

no-reply@allegro.cc (Elias) — Tue, 27 Dec 2011 17:40:18 +0000

Arthur Kalliokoski said:

IIRC Matt explained in another thread that Allegro still doesn't support GIF, even though the patent expired years ago.

We never cared about the patent, see my gif addon for A4 which was published when the patent was still active. It was up to the user of the addon to deal with the patent.

no-reply@allegro.cc (Arthur Kalliokoski) — Tue, 27 Dec 2011 18:47:45 +0000

Elias said:

We never cared about the patent

Allegro 3.12 faq.txt said:

Why can't Allegro read GIF files?

Unisys has a patent on the LZW compression algorithm that is used by
the GIF format. I want everything in Allegro to be freely usable
without any restrictions whatsoever, which means I can't include any
code that is subject to licensing or the payment of royalties.

no-reply@allegro.cc (Elias) — Tue, 27 Dec 2011 22:20:01 +0000

Quote:

Allegro 3.12 faq.txt said:

Well, 3.12 was before my time (as developer)

no-reply@allegro.cc (xtheunknown0) — Thu, 29 Dec 2011 13:56:38 +0000

Solved. Thanks to everyone.

#SelectExpand
  1#include 
  2#include 
  3#include 
  4#include 
  5#include 
  6#include 
  7#include 
  8#include 
  9
 10int main(int argc, const char *argv[])
 11{
 12   ALLEGRO_DISPLAY *display;
 13   ALLEGRO_BITMAP *bmp;
 14   ALLEGRO_FS_ENTRY *entry;
 15   int i;
 16
 17   if (!al_init())
 18      return 1;
 19   al_init_primitives_addon();
 20   al_init_font_addon();
 21   al_init_ttf_addon();
 22
 23   display = al_create_display(640, 480);
 24   if (!display) {
 25      return 1;
 26   }
 27
 28   al_init_image_addon();
 29   ALLEGRO_PATH *path = al_get_standard_path(ALLEGRO_RESOURCES_PATH);
 30
 31   al_append_path_component(path, "resources");
 32   al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 33   ALLEGRO_FONT *font = al_load_ttf_font("DejaVuSans.ttf", 12, 0); 
 34   if (!font)
 35    return 1;
 36
 37   al_remove_path_component(path, -1);
 38   al_append_path_component(path, "data");
 39   al_change_directory(al_path_cstr(path, '/'));  // change the working directory
 40   al_draw_textf(font, al_map_rgb(255, 255, 255), 200, 400, 0, "%s", al_path_cstr(path, '/'));
 41   ALLEGRO_FILE *file;
 42
 43   /* Set up PhysicsFS. */
 44   if (!PHYSFS_init(argv[0]))
 45      return 1;
 46
 47   if (!PHYSFS_addToSearchPath("ex_physfs.zip", 1)) {
 48      return 1;
 49   }
 50
 51   al_set_physfs_file_interface();
 52
 53   if (!(bmp = al_load_bitmap("smiley.bmp")))
 54     return 1;
 55
 56   al_draw_bitmap(bmp, 0, 0, 0);
 57   al_flip_display();
 58   al_rest(4.0);
 59   al_destroy_path(path);
 60
 61   return 0;
 62}