Hi to all, i am making an asteroid clone game and i am stuck at wrap around screen edges function, without it everything is fine, when i hit the asteroid it breaks into 3 smaller asteroids, and so on. but they off screen. so in order to wrap them around the screen i had made this function in asteroid class (function is at the end of code part called AsteroidVsScreen())

and now for the part in main where i call this function

then the part of the code that refreshes asteroids on the screen

iter = AsteroidList.begin();
while(iter != AsteroidList.end())
{
  
  // Retrieve the asteroid that the iterator points at
  asteroid& s = *iter;
  s.refreshAsteroid(Asteroid,font24);

iter ++;
  
}

Any suggestions would be great

Your first problem is mixing drawing with logic. You should not both alter position and draw in the same function. Split your functions apart and keep any logic separate from any drawing.

Ideally, your loop should look like this :

while (!game.Quit()) {
   game.CheckInputs();
   game.Update(time_passed);
   game.Display();
}

You have input logic, update logic, and drawing all separated out.

Update logic checks for collisions, and marks asteroids and bullets as dead, and updates their positions, as well as the position of the player. Drawing just draws, based on the state of the game. Input logic affects turn rate and acceleration, or angle and velocity of the player, or anything else controlled by the user.

Your update function should probably look something like this (pseudocode) :

Thank you Edgar Reynaldo, but maybe you know how could i complete this game with such code structure: logic and drawing together? or this is impossible? I need only to solve the combination of: asteroids being on the screen and breaking into smaller asteroid, problem. So i'll have an alpha version of this game working
(i'll rewrite all the code with right functions positions afterwards for beta + other)

It's not impossible, but it can make things harder. It's certainly messier.

I'll just let you know, you're doing it The Hard Way^TM. If you separate everything out, it will be much easier to code. I even gave you an example of what your Update function would look like. I don't want to set a bad example by helping you do it the wrong way.

Ok, but wait a sec, look at code again if i put line 76-78 from asteroid class function asteroid::refreshAsteroid()
into asteroid function asteroid::AsteroidVsScreen()
it will separate drawing from logic because in main I call AsteroidVsScreen()(that will make logic) in line 11 in one loop.

And I call s.refreshAsteroid(Asteroid,font24) (that makes drawing) in other loop

but still it doesn't work. Or i don't understand the separation thing?

Yes, that would help. If you do that, you should change the name of the function to reflect that it updates the state of the asteroid, and doesn't just fix the screen position.

Be specific - what do you expect it to do, and what is happening instead?

I expect that asteroid::refreshAsteroid() function would work normally on new created 3 asteroids after the big one is destroyed,(it works on big one) but instead 3 asteroids get the needed size, but their positions (x and y ) becomes (0,0) and they don't move, if i don't use asteroid::refreshAsteroid() part:
if(xposition > Width)
112{
113xposition=0;
114}
115
116else if(xposition < 0)
117{
118xposition = Width;
119}
120
121if(yposition > Height)
122{
123yposition =0;
124}
125
126else if(yposition < 0)
127{
128yposition = Height;
129}
130

it works, but my asteroids need to be on screen if not destructed with a bullet or ship

What is the value of n? Also, you are adding the data pointed to by a new asteroid. That means you leak the address (and memory) of the asteroid you just created. Don't use *new, just use the asteroid constructor.

Then you are setting their position and velocity to zero somewhere else, because the constructor takes the position values you passed to it, and their velocity shouldn't be changing either.

Use your IDE's find function, and look at all the instances of the position and velocity variables, and figure out which lines are changing the values. Because AsteroidVsScreen doesn't change the velocity, and it only changes the position if they go off screen.

the n is 0, it doesn't do anything(forgot to rewrite that).

after experimenting a bit i found out that AsteroidVsScreen only adds speed 1 time to new smaller asteroids, constructor gets position but somehow AsteroidVsScreen gets that x and y isn't on screen and makes them 0 0 then adds x=0+speed and stops, but why it stops, why AsteroidVsScreen only goes for 1 time for the new asteroid.

Well, I can't guess what is wrong anymore. I need to see all of your code together if you want me to figure out what is wrong. Post a zip file of all your source code and I will take a look at it.

Edgar Reynaldo, here is my zip file, if you could check it, that would be really helpful, and thank you for your time spent on my game problem

There's no attachment...

sorry for that i am trying to find a way to post it, ok now it should be working, do you need full game file or this source?

Edit your post and look in the bottom right of the screen for 'attachments for use with substandard browsers', or use Firefox or Chrome to upload your attachment.

Edit
Well, first off, you need to fix your formatting. Use consistent indentation with the same number of spaces per level everywhere, or use tabs exclusively.

I found the problem. It is in your constructor. Your default constructor sets values for Width and Height, but your Asteroid::Asteroid(int,int,int) constructor does not. This means they are probably 0, but are really uninitialized. That is why if (xposition > Width) {xposition = 0;} always sets the value to 0.

THANK YOU EDGAR Reynaldo!!!!!!!!
YOU WHERE RIGHT it works now, how could i be so blind and don't see this mistake
i've add height and width to constructor and everything works!!!!!!!!

To prevent this problem in the future, google for 'initialization list', and then always write one in your constructors that initializes every member variable to a set value.