Hi all.4 days ago i've begin to program a fight game.
Now i've finish and i'm testing it.
I've found a bug in the menu for select caracter.
The menu' appear but when i press right or left key the game crash
This's the code:

xsel=this's for cech what caracter is now "selected"
xlimdes=it's the max value xsel can be take
xlimsin=it's the min value xsel can be take
imgsel=the sprite of the "selection image"
yselmen=the y coordinate of the sprite
x1,x2,x3,x4,x5=the x coordinates of the sprite
finetutto=a var tell "movmenu" can't be use ingame.

Where's the problem?
Really thanks.
Ps:sorry for bad english.:-X

I don't think it's in the code you posted, unless imgsel or buf is messed up somehow. Just because you press left or right causes a crash doesn't mean that the problem is right there. Have you tried figuring out exactly where it crashes using a debugger?

You've reason.The problem is the bmp,i've save it at 8 color and so allegro haven't read it.
But now,I can see the selection image,but i can't go over the first player,if i push right the img appear at the first player and if i relese it the img disappear and if i push again the right button the img appear always at the first player.:o
Can help me?
Thanks

You should show us the code where imgsel is updated. Crashes are usually related to drawing null BITMAP objects, or drawing objects which aren't BITMAPs.

Also, please tell us if you're using datafiles or not.

--- Kris Asick (Gemini)
--- http://www.pixelships.com

Now i've resolve the problem with this code,but now the img remain in the screen at the first player and i can't move it...:o
No,i'm not using a .dat file.

Thanks

I'm assuming the above variable is an integer. The equals sign (=) is an assignment operator (unless you've overloaded it, but it's impossible to tell from the code you've given), which means that you assign 1 to finetutto and evaluate it as a boolean conditional.

Same thing here. I'm pretty sure the above statements will always be true. To check if a value is equal to another one make sure you use the comparison operator (==).

Perhaps you manually entered the code and forgot an equals sign? This is where copy/paste is your friend: it's faster and it makes sure we see the exact code you're having problems with. It might also help to see a more complete picture (i.e. show more or all of the code).

In the case of xsel, you then go on to check if it equals 2, 3, 4, and 5. Unless it is being changed in a separate thread you should know as soon as the first is true that the others have to be false. For this reason, it appears that you should be using an else...if ladder:

Or even cleaner is a switch statement:

Note that an else...if ladder or switch statement are only applicable if xsel doesn't change during these checks.

Sorry, I assume English isn't your first language? I'm having trouble understanding... It would help if you posted all the code (assuming it's not too much) and any error messages would also help. Perhaps if you run from the command-line you will get text output from Allegro?

Try to explain what each block of code does with comments. Especially try to explain what each variable represents and what type it is. More descriptive variable names would also help.

Also, there doesn't seem to be anything that prevents xsel from going below 1 or above 5. If it's out of range should it be moved back into range or do you just want to ignore it??

Wow!Really Really thanks for the help.
I've change my code with it:

And now the menù work fine;)
Thanks for the tip (i think thet's the correct work:-X)
I think i will have other problem with this game...;D
Ps:yes,i'm not english,i'm italian.
Thanks for the help

and...

Those prevent it from going out of range.

Guess I missed that...

If you ask me the check should be applied inside the function that accesses the variable. Those functions could be called elsewhere and if you forget to implement the check you could again go out of range. On top of that, if you implement the check in the increment/decrement functions it would eliminate a redundant check before calling the function (assuming the function could at some point be called elsewhere).

It would also clean up the game logic a bit.

void movmenu()
{
    if(finetutto==1)
    {
        if(key[KEY_RIGHT])
            incremento();

        if(key[KEY_LEFT])
            decremento();

        // Redraw.
        visualsprite();
    }
}