I'm using the code for the LS button (http://www.loomsoft.net/util_lsbutton.shtml) and was just trying to get rid of one of the functions that was there originally. So far it seems to work fine except for the fact that it doesn't play the sound effects.

Shouldn't you call the sounds function somewhere?

The problem I noticed is that when you send a value to sound_status it's either PLAY_SOUND_ON || PLAY_SOUND_DOWN

when you check the sound_status you should be checking for these instead of
SOUND_STATUS_ON || SOUND_STATUS_DOWN

int button::is_clicked(void)
{
if(is_mouse_over())
{
if(!(mouse_b & 1) && mouse_status == NOT_ON_FOCUS)
{
mouse_status = MOUSE_STATUS_UP;
draw_frame = DRAW_FRAME_ON;
sound_status = PLAY_SOUND_OFF;/*I'm assuming that this is what was supposed to be played here/

}

else if(mouse_b & 1 && mouse_status != NOT_ON_FOCUS)
{
mouse_status = MOUSE_STATUS_DOWN;
draw_frame = DRAW_FRAME_DOWN;
sound_status = PLAY_SOUND_DOWN;
}

else if(!(mouse_b & 1) && mouse_status == MOUSE_STATUS_DOWN)
{
mouse_status = MOUSE_STATUS_UP;
draw_frame = DRAW_FRAME_ON;
sound_status = PLAY_SOUND_ON;

return TRUE;
}
}

else if(!(mouse_b & 1))
{
mouse_status = NOT_ON_FOCUS;
}

else
}
draw_frame = DRAW_FRAME_OFF
}

return FALSE
}

void button::draw(BITMAP *bitmap_buffer)
{
if(draw_frame == DRAW_FRAME_DOWN)
{
if(down_bitmap != NULL)
{
acquire_screen();
draw_sprite(bitmap_buffer, down_bitmap, x_position, y_position);
release_screen();
}
}

if(draw_frame == DRAW_FRAME_ON)
{
if(on_bitmap != NULL)
{
acquire_screen();
draw_sprite(bitmap_buffer, on_bitmap, x_position, y_position);
release_screen();
}
}

if(draw_frame == DRAW_FRAME_OFF)
{
if(off_bitmap != NULL)
{
acquire_screen();
draw_sprite(bitmap_buffer, off_bitmap, x_position, y_position);
release_screen();
}
}
}

void button::sounds(void)
{
if(sound_status == PLAY_SOUND_DOWN)
{
if(down_sound != NULL)
{
if(off_sound != NULL)
stop_sample(off_sound);
if(on_sound != NULL)
stop_sample(on_sound);
if(down_sound != NULL)
play_sample(down_sound, 255, 127, 1000, FALSE);
}
}

if(sound_status == PLAY_SOUND_ON)
{
if(down_on != NULL)
{
if(off_sound != NULL)
stop_sample(off_sound);
if(on_sound != NULL)
play_sample(on_sound, 255, 127, 1000, FALSE);
if(down_sound != NULL)
stop_sample(down_sound);
}
}

if(sound_status == PLAY_SOUND_OFF)
{
if(off_sound != NULL)
{
if(off_sound != NULL)
play_sample(off_sound, 255, 127, 1000, FALSE);
if(on_sound != NULL)
stop_sample(on_sound);
if(down_sound != NULL)
stop_sample(down_sound);
}
}
}

Hope this helps, If i'm not even close i'm sorry.

All you did was change this line, correct?
sound_status = PLAY_SOUND_OFF;/*I'm assuming that this is *what was supposed to be played here*/

which line?

Nada :/

And I am calling the function in the game state I'm using it in, it doesnt really make a difference and I figure I shouldn't have to anyway.

Sorry, I tried.

Thanks though I can't really understand why the sound won't work while the drawing will, despite the fact that both functions are made the exact same way.

Edit:

It used to say:

    else if(!(mouse_b & 1))
    {
       mouse_status = NOT_ON_FOCUS;
       draw_frame = DRAW_FRAME_OFF;
       sound_status = PLAY_SOUND_OFF;
    }

Dunno if it made a difference though.

Edit again!

Oops typo, it's suppose to say PLAY_SOUND not SOUND_STATUS (still not working though.)

The sounds function needs to be called whenever the value of sound_status changes. That means that when you set sound_status = PLAY_SOUND_OFF, you need to call sounds(); right afterwards.

Why is it any different though. Then logically I should have to call the draw function right after the value of draw_frame changes, but I don't..

Edit:

That doesn't seem to work either.

If you look at the sounds function, you will see that it starts and stops sounds, whereas the draw function actually redraws frames. You don't need to "redraw" sounds. Clearly, the sounds function is meant to be called when the sound needs to change.

If it doesn't work, are you sure that the sounds are loaded?

Hmm.. Well the sounds are being loaded just fine. Before I made this change it worked perfectly.. I tried taking out the stop_sample in each of the if statements and it worked, sorta.

SO, problem solved?

Yup, except for the fact that it crashes when I press the button and just before I do it sounds as if it plays the sound file about 100 times. Don't I need to use stop_sample or else when I go to play a different sound (when the status changes) it'll play the previous one as well?

You need something like this:

if(play_this_sound)
{
   play_sample(this_sound);
   play_this_sound = false;
}

That way it only calls play_sample once