Please help me - I want change my code that in code were classes, constructors and destructors but I don't know where must be for example: BITMAP *board = NULL; set_color_depth(32) and other things in my code - could you change my code that it includes classes, constructors and destructors ?? Please help

It is my board:
http://img407.imageshack.us/img407/2996/boardnj8.jpg
It is my pawn:
http://img409.imageshack.us/img409/5185/pawnyi0.jpg

It is my code:

MERRY CHRISTMAS!!!. HO! HO! HO!.

marry christmas hehehe But is this answer for my problem ?

No. I'm guessing that Albin Engström is hinting that this may be Christmas time, but we're not feeling benevolent enough to do all the coding for you. We can help, but firstly you really need to pick up a C++ book, or check out the on-line tutorials, and try to work it out for yourself. If you get stuck, then maybe we can help you.

But in c++ books don't write where should be:
allegro_init();
install_keyboard();
set_color_depth(32);
set_gfx_mode(GFX_AUTODETECT,1024,768,0,0);
buffer=create_bitmap(SCREEN_W,SCREEN_H);
BITMAP *board = NULL;
BITMAP *pawn = NULL;
BITMAP *buffer = NULL;

in classes or in main ??

For the initialization (allegro_init(), etc.), that should be in the main function.

Classes (in my opinion) should just give the main function bitmaps to draw, or even just their position. Although after you initialize allegro in the main function, classes can use allegro functions.

I hope this answers your question. (And I hope that my answer is valid. )

I change my code but something is wrong - what is wrong ??

are you kidding?

[EDIT]
but to name one thing which is totally wrong:
don't use goto

also, you can't just write code into a class without putting it into a method. I think you should inform yourself about the concept of object-orientation before trying to use classes.

Sorry, I left my psychic powers behind somewhere. Please explain what you mean by "something is wrong."

We will not do your homework for you, either.

There are a few things like that in the code that are bad, and he was told about them last time he posted about his programs not working.

so I have questions:

1. in the class is this must be private or maybe something else ??:

BITMAP *board;  
BITMAP *pawn; 
BITMAP *buffer;

??

2.

constructor in the class should be ?????:
boardboard (BITMAP a, BITMAP b, BITMAP c)  //constructor
{
           *board=a;
           *board=b;
           *board=c;
           
}

3.

constructor in the main ????- what is wrong ??:
boardboard something ("board.bmp","pawn.bmp",NULL);  //constructor

4. destructor in the class - what is wrong :

~boardboard(a, b, c)   //destructor
{
destroy_bitmap(board); 
destroy_bitmap(pawn); 
destroy_bitmap(buffer); 
}

5. destructor in main - what is wrong :
something.boardboard::~boardboard(BITMAP a, BITMAP b, BITMAP c); //destructor

No, they don't have to be private, but they should be.

Well for one thing, you're assingning the board pointer three different values consecutively, so the first two lines do nothing. Secondly, it should be:
board=&a;

Well, you haven't given any type information about the arguments that the function takes. I don't know what C++ defults too if you omit this information. ints? Your destructor doesn't need to take any arguments anyway (I don't even think destructors can take arguments).

You do not call the destructor yourself. These are called automatically when you delete the object.

edit: had accidentally put "*board=&a"

Okay, I'm just going to be blunt as hell.

You have no idea what the hell you are talking about. You don't know what classes or objects are, what they represent, or how to use them. And you're trying to shoehorn a paradigm that you don't understand onto existing code that you probably don't understand either.

GET A C++ BOOK. FOLLOW IT. START FROM THE BOTTOM.

Then come back when you have questions that make sense.

May I suggest this C++ book?

I learned from it, it has stuff about about classes and basic programming practices, such as the standard library. I highly suggest it.

Steve head hurt >_<

Steve smash steve go boom boom steve no likey

LennyLen thank you - you are very helpful - Can I give you some points for help ?

I read c++ books and now I want use my knowledge but it is now the most complicated programm which I want write so I want that you help me - do some of you have really to be such boorish ?
Your advices very help me understand classes, constructors, destructors and ALLEGRO - really .

I change my code - could you now what in this code is wrong ??

If you could please post the errors, that would be good. I, for one, do not like to take the time to compile your code. I did with yours though, just for the heck of it. [Edit:] Yes, I did just contradict myself.

I spotted one problem: You did not declare your "buffer" bitmap before trying to set it to a value.

The other problems I cannot figure out, because I have no clue what boardboard is, and what the point of most of the functions are.

[EDIT2:]

I just noticed something... you are trying to use strings as bitmaps when creating a "boardboard". This cannot be done. If you want to load a bitmap, you would want to use this.

[EDIT3:] After more attempts to fix your code, I gave up.

Personally, I would re-write my code and use comments more often. It seems your code is very disorganized, and you don't even use the game loop function in your main function. (At least I don't think so.)

boardboard (BITMAP a, BITMAP b, BITMAP c)  //constructor
{
           *board=&a;
           *board=&b;
           *board=&c;
           
}

WTF is that?

It's slightly amusing but probably more depressing, thats what it is!

kosmitek:

1) You should probably put the class declaration in its own header (.H) file and the implementation in a .CPP file:

something.h:

class boardboard
{
   public:

      boardboard (BITMAP a, BITMAP b, BITMAP c);   // Constructor
      ~boardboard(); // Destructor

      void function();

   private:
      BITMAP *board;
      BITMAP *pawn;
      BITMAP *buffer;
};

something.cpp:

2) You should put your movement TEST routines in a regular function, not a class. You should keep your movement LOGIC routines in the class:

That would also take care of the need for the GOTO statement in there: it would be processed fine without ever needing that.

3) As Durnus said, you are trying to pass strings: boardboard something ("board.bmp", "pawn.bmp", NULL); into a function that is expecting a BITMAP pointer: boardboard(BITMAP a, BITMAP b, BITMAP c) (which should be <b>boardboard(BITMAP *a, BITMAP *b, BITMAP c), by the way.

You would want to change either:

...or...

4) I'm not entirely certain what you're doing with all those pointers (tab1 and tab2), but you could DEFINITELY be able to simplify those, or get rid of them entirely (why have an array with the VALUES 0..9, instead of just using "0..9" as numbers?).

We went through this last thread... I don't have any idea what C++ book you read but you gotta find something better. I hope it's not a Sams Teach Yourself C++ in 24hr books either.

Look, the very fact that you're trying to impose an object-oriented design approach onto something that isn't designed that way in the first place is the clearest indicator we could possibly get that you just don't understand object-oriented programming. Get a different book, read it slowly, and follow the exercises if there are any.

May I suggest my previously suggested C++ book?

As I have said, it doesn't include just classes, but basic C++ programming. (No offence intended with the basic stuff, but it is a very good book to learn classes from.

And as X-G said, you are trying to make classes for something that doesn't need them.

Why, what's wrong with them? It's what got me started. And no-one's died yet

Ok, so my games never work, the PC resets with every recompile, and every time I get to the point where I can execute my program I need to re-install the windows. But otherwise it's fine.

Durnus - my programm shouldn't use classes, constructor and destructor ?? Why ??

And why I shouldn't use "goto" ??

I change my code
programme and it is compiling and gun, but is it in code everything okey ?

everything okay ??

PS. thanks TeamTerradactyl for your advices

This is a joke right? This is not even closely valid C++- - code! Did you ever try to compile it? Even if it would, by skimming through it, I can say it would crash like hell... Listen to people's advises or at least post the freaking compiler-errors!!

you shouldn't use classes, constructors and destructors because it seems you have no idea how to use them.
you shouldn't use goto because it's dated, makes your code hard to read, and there's is nothing which you can do with goto, which can't be done without goto in a more elegant way.

if you really read a c++-book (which i doubt), you should have come across a thing called while-loop. you could replace your goto with this statement.
also, passing BITMAPs to your function-function (by the way: nice naming), is senseless in your case, but passing NULL-pointers seems like even worse.
there is just so much wrong with your code, it's hard to make a start.

But what is wrong in this code:
(IN attachment you have all my program)

This programm guns very good so what is wrong
imaxcs you said:
"I can say it would crash like hell"
but it doesn't crah

All right, guys, let's just stop taking this thread seriously. Either it's a troll, or so blithely ignorant as to be beyond our help. We've already given the only correct response: Get a C++ book and follow it from the beginning to the end.

X-G I am not troll
I use your advices and thanks some of you my programm gun but what is in this programm wrong (without "goto") ??

X-G if you don't want help me you didn't write.

X-G my programm is almost good and you can only criticize me - you do not want even to say what is bad despite that my programme great run.

And "goto" must be because if somebody will press other button than: "->; <-" then program go to "direction" - and player will have press "->; <-" - the number of eyes will not change, if I use "continue" then player also will have press "->; <-; Esc" but the number of eyes will change - and I don't want that the number of eyes change until player press "->" or "<-".

kosmitek: Attached is a cleaned-up version of your code.

Since you really don't need to use a class/struct for this program, I have removed them. I also added a bunch of comments so you could read the changes I've made, or else what's going on in the program.

Thank you for posting your source code so I could see what your game was supposed to do.

You may want to convert your .BMP images into .PCX or another format: The filesize will be a LOT smaller (the BMP images are uncompressed, while PCX are).

I also changed this to WINDOWED mode instead of full-screen (my computer crashes a lot whenever it's in full-screen, for some reason), so if you need to change it back, you can do so.

I hope this helps.

I think that if you WANTED to use a class/struct, the best thing to do would be to have something that has a lot of different data: your "pawn" could be an animated tile, and so the pawn could be a class, or if you have several different "boards", you could make each of those with a separate class (like, one could have a wood background with the "tiles" a few inches apart, and another could have a stone background with the "tiles" in more of a circular pattern and different coordinates, etc.).

What you're doing right now doesn't really need a class, since that looks like you're trying to use your class as a substitute for the main body of your game.

Anyway, hope this helps (and others can take a look at the code and make sure I didn't leak a bunch of memory )

This site should be enough.

TeamTerradactyl thank you very much for your help and comments in the code.

I wanted use class, constructor and destructor because I want develop my game and for example: "destroy_bitmap" - it was ideal to use destructor etc.
But if I want to develop my game for example that if player will stand up on same field he will get money - so should I use now class, constructor and destructor in this code (because I want that my final version of game using classes, constructors, destructors etc.) ?

kosmitek,

Let's say that that little "pink pawn" that you had in your code was going to become a nice little animated sprite (like a swirling "rock" or a "chess piece" that occasionally moves or whatever).

   +---+---+---+---+---+---+
   | X |   | X |   |   |   |
   +---+---+---+---+---+---+
   |   |   |   | X |   |   |
   +---+---+---+---+---+---+