Movement doesnt go on when holding button

PamperBoy

Hi im kinda new to C++ and Allegro. And im using tutorials. But i have a problem. I Made a player class where i want a function (controls) to call in main. somehow i dont get it to work, so i put the movement in main. somehow that works but, it only moves once after pressing the button. It doesnt continue.

Can someone help me with this?
1st: how do i make the movement continues. (this is more important tho)
2nd: how do i place it in the class.

showing the main.cpp, InputManager class and Player class.

#SelectExpand
   1#include<iostream>
   2#include<allegro5\allegro5.h> 
   3#include<fstream>
   4#include"Map.h"
   5#include"Global.h"
   6#include"Player.h"
   7#include"InputManager.h"
   8#include<allegro5\keyboard.h>
   9
  10using namespace std;
  11
  12int main()
  13{
  ALLEGRO_DISPLAY *display;

  const float FPS = 60.0;
bool done = false;

//initialized. If not you get error message.
  20
  //initialized. If not you get error message.
  22
  if(!al_init())
{  al_show_native_message_box(NULL, "Error", "Error",
  "Cannot initialize Allegro", NULL, NULL);
  return -1;
}
   
  display = al_create_display(ScreenWidth, ScreenHeight);
  30
if(!display)
  {  al_show_native_message_box(NULL, "Error", "Error",
  "Cannot create display", NULL, NULL);
  return -1;
}

  //al_set_window_position(display, 200, 200);

  al_init_primitives_addon();
al_install_keyboard();
  41
  ALLEGRO_TIMER *timer = al_create_timer(1.0 / FPS);
ALLEGRO_EVENT_QUEUE *event_queue = al_create_event_queue();
ALLEGRO_KEYBOARD_STATE keyState;

  al_register_event_source(event_queue, al_get_keyboard_event_source());
  al_register_event_source(event_queue, al_get_timer_event_source(timer));
  al_register_event_source(event_queue, al_get_display_event_source(display));
  
InputManager input;
Player player;
Map map;
  53
map.Init();
player.Init();
//player.Draw(display);
  57
al_start_timer(timer);
  59
  while(!done)
{
  ALLEGRO_EVENT ev;
  al_wait_for_event(event_queue, &ev);
  al_get_keyboard_state(&keyState);
  65
  
  if(ev.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
      {
          done = true;
  }
  71
  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_ESCAPE))
  {  
    done = true;
  }
  
  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_RIGHT))
    player.velx = player.speed;

  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_LEFT))
    player.velx = -player.speed;
  82
  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_DOWN))
    player.vely = player.speed;

  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_UP))
    player.vely = -player.speed;
  88
  else
  {
    player.velx = 0;
    player.vely = 0;
  }
  94
  player.x += player.velx;
  player.y += player.vely;
  97
  map.Draw(display);
  player.Draw(display);
  
}
 102
al_destroy_display(display);
al_destroy_timer(timer);
al_destroy_event_queue(event_queue);
 106
  return 0;
 108}

#SelectExpand
  1#include "InputManager.h"
  2
  3
  4InputManager::InputManager(void)
  5{
  6}
  7
  8
  9InputManager::~InputManager(void)
 10{
 11}
 12
 13bool InputManager::IsKeyPressed(ALLEGRO_EVENT ev, int key)
 14{
 15  if(ev.type == ALLEGRO_EVENT_KEY_DOWN)
 16  {
 17    if(ev.keyboard.keycode == key)
 18      return true;
 19  }
 20  return false;
 21}
 22
 23bool InputManager::IsKeyPressed(ALLEGRO_EVENT ev, std::vector<int> keys)
 24{
 25  if(ev.type == ALLEGRO_EVENT_KEY_DOWN)
 26  {
 27    for(int i = 0; i < keys.size(); i++)
 28    {
 29      if(ev.keyboard.keycode == keys[i])
 30        return true;
 31    }
 32  }
 33  return false;
 34}
 35
 36bool InputManager::IsKeyReleased(ALLEGRO_EVENT ev, int key)
 37{
 38  if(ev.type == ALLEGRO_EVENT_KEY_UP)
 39  {
 40    if(ev.keyboard.keycode == key)
 41      return true;
 42  }
 43  return false;
 44}
 45
 46bool InputManager::IsKeyReleased(ALLEGRO_EVENT ev, std::vector<int> keys)
 47{
 48  if(ev.type == ALLEGRO_EVENT_KEY_UP)
 49  {
 50    for(int i = 0; i < keys.size(); i++)
 51    {
 52      if(ev.keyboard.keycode == keys[i])
 53        return true;
 54    }
 55  }
 56  return false;
 57}

#SelectExpand
  1#include "Player.h"
  2
  3
  4
  5
  6Player::Player(void)
  7{
  8}
  9
 10
 11Player::~Player(void)
 12{
 13}
 14
 15void Player::Init()
 16{
 17  x = 50;
 18  y = 50;
 19  velx = 0;
 20  vely = 0;
 21  speed = 2;
 22}
 23
 24void Player::Update()
 25{
 26  //Player::Controls();
 27}
 28
 29void Player::Draw(ALLEGRO_DISPLAY *display)
 30{
 31  al_draw_circle(x + 10, y + 10, 5, al_map_rgb(255, 200, 0), 2.0);
 32  al_flip_display();
 33    
 34}
 35
 36/*void Player::Controls()
 37{
 38  if(input.IsKeyPressed(ev, ALLEGRO_KEY_RIGHT))
 39    velx = speed;
 40  
 41  else if(input.IsKeyPressed(ev, ALLEGRO_KEY_LEFT))
 42    vely = -speed;
 43
 44  else
 45    velx = 0;
 46
 47  x += velx;
 48  y += vely;
 49}*/

Hyllis

Hello,

IsKeyPressed (ALLEGRO_EVENT_KEY_DOWN) only trigger once, when you press the key.
Personally, I've a boolean array (size ALLEGRO_KEY_MAX). Every update I loop through it ; I keep in there every key state, when you press (ALLEGRO_EVENT_KEY_DOWN) => true, when you release (ALLEGRO_EVENT_KEY_UP) => false.

Maybe there is another solution? which would be useful for me, too. But I don't think so.

Dizzy Egg

Yeah, what Hyllis said. So, you need to set a flag when the key_down event happens, and then reset it when the key_up event happens; here is some psuedo code:

#SelectExpand
  1
  2bool key_left_down;
  3
  4if(key_down.key_left)
  5{
  6    key_left_down = true;
  7}
  8
  9if(key_up.key_left)
 10{
 11    key_left_down = false;
 12}
 13
 14if(key_left_down)
 15{
 16    position = position - 1;
 17}

Thread #613957. Printed from Allegro.cc