What is going on here?

j0rdant13

Following a tutorial and getting this error:
instances\instances\main.cpp(65): error C2143: syntax error : missing ';' before '.'

Am i missing something or is the compiler taking the piss?

code for the header and .cpp here:

#SelectExpand
  1#pragma once
  2
  3#include <allegro5\allegro.h>
  4#include <allegro5\allegro_font.h>
  5#include <allegro5\allegro_ttf.h>
  6
  7#include "GameScreen.h"
  8#include "SplashScreen.h"
  9#include "TitleScreen.h"
 10
 11class ScreenManager
 12{
 13private:
 14  ScreenManager();
 15  ScreenManager(ScreenManager const&);
 16  void operator=(ScreenManager const&);
 17
 18  GameScreen *currentScreen, *newScreen;
 19public:
 20  static ScreenManager &GetInstance();
 21  ~ScreenManager(void);
 22
 23  void AddScreen(GameScreen *screen);
 24
 25  void LoadContent();
 26  void UnloadContent();
 27  void Update(ALLEGRO_EVENT ev);
 28  void Draw(ALLEGRO_DISPLAY *display);
 29  void Initialize();
 30
 31};

.cpp:

#SelectExpand
  1#include "ScreenManager.h"
  2
  3ScreenManager &ScreenManager::GetInstance()
  4{
  5  static ScreenManager instance;
  6  return instance;
  7}
  8
  9ScreenManager::ScreenManager()
 10{
 11}
 12
 13ScreenManager::~ScreenManager()
 14{
 15}
 16
 17void ScreenManager::AddScreen(GameScreen *screen)
 18{
 19  newScreen = screen;
 20  currentScreen->UnloadContent();
 21  currentScreen = newScreen;
 22  currentScreen->LoadContent();
 23}
 24
 25void ScreenManager::Initialize()
 26{
 27  currentScreen = new SplashScreen();
 28}
 29
 30void ScreenManager::LoadContent()
 31{
 32  currentScreen->LoadContent();
 33}
 34
 35void ScreenManager::Update(ALLEGRO_EVENT ev)
 36{
 37  currentScreen->Update(ev);
 38}
 39
 40void ScreenManager::Draw(ALLEGRO_DISPLAY *display)
 41{
 42  currentScreen->Draw(display);
 43}

If u need any other code ill supply, ive tried to figure this out and its racking my brain ...

edit:
this is how im declaring stuff in the main:

#SelectExpand
  1InputManager input;
ScreenManager::GetInstance().Initialize();
ScreenManager::GetInstance().LoadContent();
//----------------
al_start_timer(timerFPS);
while(running)
{
  ALLEGRO_EVENT events;
  al_wait_for_event(event_queue, &events);
 10
  if(events.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
  {
    running = false;
  }
  if(input.IsKeyPressed(events, ALLEGRO_KEY_ESCAPE))
      running = false;
  if(events.type == ALLEGRO_EVENT_TIMER)
  {
    al_get_keyboard_state(&keyState);
    ScreenManager.GetInstance().Update(events);
    redraw = true;
  }
 23
  if(redraw && al_event_queue_is_empty(event_queue))
  {
    ScreenManager.GetInstance().Draw(display);
    al_flip_display();
    al_clear_to_color(al_map_rgb(0,0,0));
  }
}

Erin Maus

The error is somewhere in main.cpp. The code you provided is not relevant .

As per your edit, to access a static class method or variable you do this:

Foo::Bar()

Not:

Foo.Bar()

In some places, you access the ScreenManager::GetInstance the latter way. You need to do it the former.

Arthur Kalliokoski

It looks to me like it's complaining about syntax on line 65 (possible a line or three before 65) in main.cpp. Post that.

j0rdant13

the whole of my main here:

#SelectExpand
  1#include <allegro5\allegro.h>
  2#include <allegro5\allegro_native_dialog.h>
  3#include <allegro5\allegro_native_dialog.h>
  4#include <allegro5\allegro_image.h>
  5#include <allegro5\allegro_audio.h>
  6#include <allegro5\allegro_acodec.h>
  7#include <allegro5\allegro_font.h>
  8#include <allegro5\allegro_ttf.h>
  9
 10#include "ScreenManager.h"
 11#include "InputManager.h"
 12
 13#include <iostream>
 14#include <vector>
 15
 16int main()
 17{
bool running = true, redraw = false;
//------------
if(!al_init())
{
  al_show_native_message_box(NULL, "Allegro Initialization", "Allegro ERROR:", "Failed to initialize allegro!", NULL, NULL);
  return -1;
}
ALLEGRO_DISPLAY* display = al_create_display(800, 600);
if(!display)
{
  al_show_native_message_box(NULL, "Allegro Display", "Allegro ERROR:", "Failed to create a display!", NULL, NULL);
  return -1;
}
ALLEGRO_EVENT_QUEUE* event_queue = al_create_event_queue();
ALLEGRO_TIMER* timerFPS = al_create_timer(1.0 / 60);
ALLEGRO_KEYBOARD_STATE keyState;
//-----------------
//al_init_acodec_addon();
al_init_font_addon();
//al_init_image_addon();
al_init_ttf_addon();
al_install_keyboard();
//al_install_mouse();
//--------------
al_register_event_source(event_queue, al_get_display_event_source(display));
al_register_event_source(event_queue, al_get_timer_event_source(timerFPS));
al_register_event_source(event_queue, al_get_keyboard_event_source());
//----------------
InputManager input;
ScreenManager::GetInstance().Initialize();
ScreenManager::GetInstance().LoadContent();
//----------------
al_start_timer(timerFPS);
while(running)
{
  ALLEGRO_EVENT events;
  al_wait_for_event(event_queue, &events);
 55
  if(events.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
  {
    running = false;
  }
  if(input.IsKeyPressed(events, ALLEGRO_KEY_ESCAPE))
      running = false;
  if(events.type == ALLEGRO_EVENT_TIMER)
  {
    al_get_keyboard_state(&keyState);
    ScreenManager.GetInstance().Update(events);
    redraw = true;
  }
 68
  if(redraw && al_event_queue_is_empty(event_queue))
  {
    ScreenManager.GetInstance().Draw(display);
    al_flip_display();
    al_clear_to_color(al_map_rgb(0,0,0));
  }
}
 76
al_destroy_display(display);
al_destroy_timer(timerFPS);
al_destroy_event_queue(event_queue);
al_uninstall_audio();
al_uninstall_mouse();
al_uninstall_keyboard();
return 0;
 84}

thanks for the replies anyways guys this is really annoying

EDIT:
aaron you are absolutley right! why did i even do that lmao!! life saver thanks ever so much and to those for suggestions

Arthur Kalliokoski

It won't compile without all those header files, but

      ScreenManager.GetInstance().Update(events);

on line 65 looks suspicious to me (Disclaimer: I don't do C++)

Should it be

      ScreenManager(GetInstance(Update(events)));

j0rdant13

Thanks Arthur but im calling a static function so therefore i cannot do anything but ScreenManager::GetInstance().Update(); etc.. Thanks anyways

Thread #612326. Printed from Allegro.cc