drawing slow

shadyvillian

I'm having really slow reaction time when the mouse goes over my buttons. I'm using a timer for the drawing and the mouse will be over the image it will take 2 or 3 draw function calls for the over state of the button to show up. this is another window from the original, I'm not sure if that has anything to do with it. I tried increasing the timer speed but that doesn't really do anything.

#SelectExpand
  1al_start_timer(RedrawTimer);
  2
  while(Exit == false)
  {
      al_wait_for_event(EventQueue, &Event);
  6
      if(Event.type == ALLEGRO_EVENT_TIMER)
      {
          if(Event.timer.source == RedrawTimer)
          {
              Redraw = true;
          }
      }
 14
      if(Event.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
      {
          Exit = true;
      }
 19
      if(Event.type == ALLEGRO_EVENT_MOUSE_AXES)
      {
          for(unsigned int i = 0; i < Buttons.size(); i++)
          {
              Buttons[i].IsMouseOver(Event.mouse.x, Event.mouse.y);
          }
      }
 27
      if(Event.type == ALLEGRO_EVENT_MOUSE_BUTTON_UP)
      {
          if(Buttons[PRVW_BUT_MULLIGIAN].IsMouseOver() == true)
          {
              if(HandSize == 1)
              {
                  ShowMessageBox(Screen, "Error", "You can't mulligan to zero", ALLEGRO_MESSAGEBOX_ERROR);
              }
 36
              if(HandSize > 1)
              {
                  CardImages.clear();
                  HandSize--;
                  random_shuffle(PreviewDeck.begin(), PreviewDeck.end());
 42
                  for(int i = 0; i < HandSize; i++)
                  {
                      CardImages.resize(CardImages.size()+1);
                      CardImages[CardImages.size()-1].Load(CardX[i], CardY[i], "Media/Images/Card Images/" + PreviewDeck[i].Set + "/" + PreviewDeck[i].Name + ".jpg");
                  }
              }
          }
 50
          if(Buttons[PRVW_BUT_EXIT].IsMouseOver() == true)
          {
              Exit = true;
          }
 55
          if(Buttons[PRVW_BUT_RESET].IsMouseOver() == true)
          {
              CardImages.clear();
              HandSize = 7;
              random_shuffle(PreviewDeck.begin(), PreviewDeck.end());
 61
              for(int i = 0; i < HandSize; i++)
              {
                  CardImages.resize(CardImages.size()+1);
                  CardImages[CardImages.size()-1].Load(CardX[i], CardY[i], "Media/Images/Card Images/" + PreviewDeck[i].Set + "/" + PreviewDeck[i].Name + ".jpg");
              }
          }
      }
 69
      if((Redraw == true) && (al_is_event_queue_empty(EventQueue) == true))
      {
          Redraw = false;
          Draw();
      }
  }

Edgar Reynaldo

I don't see anything wrong with the code you posted so far. What is the code for the IsMouseOver function?

shadyvillian

#SelectExpand
  1void IsMouseOver(int MouseX, int MouseY)
  {
      if((MouseX >= x1+1) && (MouseX <= x2-1) && (MouseY >= y1+1) && (MouseY <= y2-1))
      {
          Over = true;
      }
  7
      else
      {
          Over = false;
      }
  }
 13
  bool IsMouseOver()
  {
      return Over;
  }

Right when I put my mouse over the image over became true and i confirmed it using cout. Could the main window be slowing this window down? When you click a button another window appears and calls a run function that has a loop so you are in that until you close it. I set the backbuffer to the new window and I'm pretty sure you can't do anything in the main window until you get rid of this one(this is how I wanted it)

Edgar Reynaldo

There's nothing wrong with that either. The hover state should be showing up instantaneously.

Show the code for your draw function.

shadyvillian

heres most of the functions

#SelectExpand
   1int Initialize()
   2{
  Screen = NULL;
  EventQueue = NULL;
   5
  int x = 0, y = 0;
  al_get_window_position(al_get_current_display(), &x, &y);
   8
  Screen = al_create_display(1050, 765);
      if(!Screen)
      {
          return ShowMessageBox(al_get_current_display(), "Error", "Failed to create screen", ALLEGRO_MESSAGEBOX_ERROR);
      }
  14
  al_set_window_position(Screen, x+75, y+97);
  al_set_window_title(Screen, "Preview Hand");
  al_set_target_backbuffer(this->Screen);
  18
  ALLEGRO_BITMAP *Icon = NULL;
  Icon = al_load_bitmap("Media/Images/Ui-Images/Icon.png");
      if(!Icon)
      {
          return ShowMessageBox(Screen, "Error", "Failed to load screen icon", ALLEGRO_MESSAGEBOX_ERROR);
      }
  25
  al_set_display_icon(Screen, Icon);
  27
  EventQueue = al_create_event_queue();
  RedrawTimer = al_create_timer(1.0 / 30);
  30
  al_register_event_source(EventQueue, al_get_mouse_event_source());
  al_register_event_source(EventQueue, al_get_display_event_source(Screen));
  al_register_event_source(EventQueue, al_get_timer_event_source(RedrawTimer));
  34
  return 0;
  36}
  37
  38
  39
  40void UnloadContent()
  41{
  al_destroy_display(Screen);
  43}
  44
  45void Draw()
  46{
  Background.Draw();
  48
  for(unsigned int i = 0; i < Buttons.size(); i++)
  {
      Buttons[i].Draw();
  }
  53
  for(unsigned int i = 0; i < CardImages.size(); i++)
  {
      CardImages[i].Draw();
  }
  58
  al_flip_display();
  60}
  61
  62void Run(const std::vector<Card> &Deck)
  63{
  const int CardX[7] = {10, 270, 530, 790, 10, 270, 530};
  const int CardY[7] = {10, 10, 10, 10, 370, 370, 370};
  66
  for(unsigned int i = 0; i < Deck.size(); i++)
  {
      for(int j = 0; j < Deck[i].NumOf; j++)
      {
          PreviewDeck.push_back(Deck[i]);
      }
  }
  74
  random_shuffle(PreviewDeck.begin(), PreviewDeck.end());
  76
  for(int i = 0; i < 7; i++)
  {
      CardImages.resize(CardImages.size()+1);
      CardImages[CardImages.size()-1].Load(CardX[i], CardY[i], "Media/Images/Card Images/" + PreviewDeck[i].Set + "/" + PreviewDeck[i].Name + ".jpg");
  }
  82
  Exit = false;
  Draw();
  al_start_timer(RedrawTimer);
  86
  while(Exit == false)
  {
      al_wait_for_event(EventQueue, &Event);
  90
      if(Event.type == ALLEGRO_EVENT_TIMER)
      {
          if(Event.timer.source == RedrawTimer)
          {
              Redraw = true;
          }
      }
  98
      if(Event.type == ALLEGRO_EVENT_DISPLAY_CLOSE)
      {
          Exit = true;
      }
 103
      if(Event.type == ALLEGRO_EVENT_MOUSE_AXES)
      {
          for(unsigned int i = 0; i < Buttons.size(); i++)
          {
              Buttons[i].IsMouseOver(Event.mouse.x, Event.mouse.y);
          }
      }
 111
      if(Event.type == ALLEGRO_EVENT_MOUSE_BUTTON_UP)
      {
          if(Buttons[PRVW_BUT_MULLIGIAN].IsMouseOver() == true)
          {
              if(HandSize == 1)
              {
                  ShowMessageBox(Screen, "Error", "You can't mulligan to zero", ALLEGRO_MESSAGEBOX_ERROR);
              }
 120
              if(HandSize > 1)
              {
                  CardImages.clear();
                  HandSize--;
                  random_shuffle(PreviewDeck.begin(), PreviewDeck.end());
 126
                  for(int i = 0; i < HandSize; i++)
                  {
                      CardImages.resize(CardImages.size()+1);
                      CardImages[CardImages.size()-1].Load(CardX[i], CardY[i], "Media/Images/Card Images/" + PreviewDeck[i].Set + "/" + PreviewDeck[i].Name + ".jpg");
                  }
              }
          }
 134
          if(Buttons[PRVW_BUT_EXIT].IsMouseOver() == true)
          {
              Exit = true;
          }
 139
          if(Buttons[PRVW_BUT_RESET].IsMouseOver() == true)
          {
              CardImages.clear();
              HandSize = 7;
              random_shuffle(PreviewDeck.begin(), PreviewDeck.end());
 145
              for(int i = 0; i < HandSize; i++)
              {
                  CardImages.resize(CardImages.size()+1);
                  CardImages[CardImages.size()-1].Load(CardX[i], CardY[i], "Media/Images/Card Images/" + PreviewDeck[i].Set + "/" + PreviewDeck[i].Name + ".jpg");
              }
          }
      }
 153
      if((Redraw == true) && (al_is_event_queue_empty(EventQueue) == true))
      {
          Redraw = false;
          Draw();
      }
  }
 160
  al_stop_timer(RedrawTimer);
  UnloadContent();
 163}

if i remove the timer and put draw before al_wait_for_event it doesnt even respond. I can't even x out the window it just hangs and I have to force exit using the stop debugger.

EDIT: these functions are part of a class and most of the variables are too. the buttons have their own class

Edgar Reynaldo

I still don't see anything wrong. Your timer is a bit slow, usual timer speed matches the refresh rate of the monitor, typically 60 or 70 Hz.

Are all your buttons slow to show the hover?

You should try timing how long it takes from when your button changes to the hover state to when the display is shown next. Then use a kind of binary search to find out what is taking so long for it to display.

#SelectExpand
  1bool hover, old_hover, hover_changed;
  2
  3if (hover = buttons[X].IsMouseOver()) {
  4   hover_changed = (hover != old_hover);
  5   old_hover = hover;
  6}
  7
  8if (hover_changed) {start = al_get_time();}
  9
 10if (redraw) {
 11   Draw();
 12   if (hover_changed) {
 13      stop = al_get_time();
 14      printf("Hover change took %f seconds to display.\n" , stop - start);
 15   }
 16}

shadyvillian

the over state changes immediately, but the over state doesn't draw for 5 seconds or so

LordHolNapul

hi,
I've not read and understood all your code but you should do the following steps in order to run quickly your images:

1) Preload everything you need from the HD with a load process.

2) Format everything you need to be quickly accessible (i.e. transform BMP into texture and MP3 into the first chunk of wave...)

3) create the main loop using POINTERS to the Graphic and the other data. Every method and function that passes parameters should use pointers unless you are transmitting int/short int/1 char/or Bool.

4) your main loop is ended, destroy everything you created , and quit.

hope this help. ::)

shadyvillian

Ok so I exported this whole module class to a standalone program and everything worked perfect with the code unchanged. What does this tell us edgar?

Edgar Reynaldo

shadyvillian said:

the over state changes immediately, but the over state doesn't draw for 5 seconds or so

Did you measure the time using the method I posted in the post before the one I just quoted? If you did, and it took 5 seconds, then it was your Draw() method taking 5 seconds to complete.

shadyvillian said:

Ok so I exported this whole module class to a standalone program and everything worked perfect with the code unchanged. What does this tell us edgar?

It depends. There has to be something different. In the program that was slow to visually update, you were using a second display. Did you load any resources used in it in the same thread that you created the display in? Or if there were any resources, were they loaded in a separate thread? That would cause them to be slow memory bitmaps. In fact, I don't see you loading your card images anywhere in the code you posted.

Your resources may be attached to another display - you'd have to ask the Allegro devs about that - that might be causing part of the problem.

The first display shouldn't be taking any processor power except for the allegro thread that runs it's window process, which should be minimal.

Still not sure what's wrong though.

shadyvillian

all the images are loaded when the main program is starting. Should I load it after I create the window that these images are being drawn to?

Edgar Reynaldo

I'm not sure, but I would guess that the answer is yes, you should load the resources used when your new display is active.

I think the whole problem is that your resources are not attached to the display that is in use. You should be able to test that fairly easily.

LordHolNapul

the process of loading is connected to the color depth of your screen...
The Setup of Allegro is always the first step to do...

shadyvillian

No I would initialize allegro then load all content including for the sub windows. then when the user clicks the button to bring up the window and i initialize that window so it shows up. I changed it so when the sub window initializes i made it load the sub windows content and now it works. I really need to learn about threads I originally wanted to load all the images in the beginning so when you open a sub window your not sitting with a blank window waiting for all the images to load.

Edgar Reynaldo

It's not about threads, and they aren't very useful with Allegro 5 as far as I can see. The problem here was that your resources were attached to a different display.

Thread #608375. Printed from Allegro.cc