Stumped

jason perkins

After Many Many hours of fiddling around the problem appears to be in how I'm saving/loading my files. I don't see what I'm doing wrong here... This was working fine until I updated my project, but now It's broken.

#SelectExpand
   1void CLayer::save(std::string a)
   2{
if (created== true)
{
  ALLEGRO_FILE* file;
   6
  file = al_fopen(a.c_str(), "w");
  
  if(file)
  std::cout <<" Opened File " << a << endl;
  11
  al_fwrite32le(file, map.getWidth());
  std::cout << "saved Map width " << map.getWidth() << endl;
  al_fwrite32le(file, map.getHeight());
  std::cout << "saved Map Height " << map.getHeight() << endl;
  16
  for (int h = 0; h<map.getHeight(); h++)
  {
    for (int w = 0; w<map.getWidth(); w++)
    {
      std::cout << "iteration " << h*map.getWidth()+w << endl;
      al_fwrite32le(file, map.map[h*map.getWidth()+w].getId());
      std::cout << "saved " << map.map[h*map.getWidth()+w].getId() << endl;
    }
  }
  26
  al_fclose(file);
  std::cout << "Saved " << a << endl;
}
  30
  31}
  32
  33
  34oid CLayer::load(std::string a, std::string b)
  35{
ALLEGRO_FILE* file;
ALLEGRO_FILE* file2;
  38
file = al_fopen(a.c_str(), "r");
file2 = al_fopen(b.c_str(), "r");
  41
if (file && file2)
{al_fclose(file2);
  {
    int fwidth = 0;
    int fheight = 0;
  47
    fwidth = al_fread32le(file);
    cout << "Loaded file Width - " << fwidth << endl;
    fheight = al_fread32le(file);
    cout << "Loaded file Height - " << fheight << endl;
    create(fwidth, fheight, b);
    cout << "created map with width " << fwidth << " Height " << fheight << " with pallet " << b << endl;
  54
    for (int h = 0; h<map.getHeight(); h++)
    {
      for (int w = 0; w<map.getWidth(); w++)
      {
        map.map[h*map.getWidth()+w].setId(al_fread32le(file));
        cout << "iteration " << h*map.getWidth()+w << endl;
        cout << "Map Id " << map.map[h*map.getWidth()+w].getId() << endl;
        
        map.map[h*map.getWidth()+w].setBmp(pallet.pallet[map.map[h*map.getWidth()+w].getId()].getBmp());
      }
    }
  66
    al_fclose(file);
    std::cout << "Loaded Map:"<< a << " With Pallet :" << b << endl;
    loaded = true;
  }
}
else
  std::cout << "Could Not Load " << a << " Using " << b << endl;
  74}
  75
  76void CLayer::create(int a, int b, std::string c)
  77{
ALLEGRO_FILE* file;
file = al_fopen(c.c_str(), "r");
if(file)
{
  al_fclose(file);
  83
  created = true;
  pallet.pallet.clear();
  pallet = CPallet(c);
  map = CMap(a, b);
  88
  CResourceGrabber& rg = rg.getInstance();
  map.setAllBmps(pallet.getBmp(0));
  brush.clear();
  brush.push_back(CTile(pallet.getBmp(0)));
  brush[0].setX(0);
  brush[0].setY(0);
  95
  brushWidth = 1;
  brushHeight = 1;
  brushVisible = false;
  map.setVisible(false);
  pallet.setVisible(false);
  menu.setVisible(true);
  std::cout << "Created a " << a<< "X"<< b << " Map for your amusement!\n";
}
else
{
  std::cout <<"Could Not Open " << c << " Creation Aborted!\n ";
}
 108
 109}

This is what I get from my console. Everything appears to save fine, and then when I load I get seemingly random -1.

{"name":"603620","src":"\/\/djungxnpq2nug.cloudfront.net\/image\/cache\/c\/e\/ce65aed8704e8cf820a069ae5b2971f6.jpg","w":690,"h":726,"tn":"\/\/djungxnpq2nug.cloudfront.net\/image\/cache\/c\/e\/ce65aed8704e8cf820a069ae5b2971f6"}
Really not sure why this happens.

Edgar Reynaldo

jason perkins said:

                  map.map[ (h+hh)*map.getWidth()+w+ww ].setId(brush[hh*brushWidth+ww].getId()); //This the problem

My guess is that you are accessing an index of brush that is out of bounds to begin with, and so you are getting a random number from getId().

Use a debugger - set a breakpoint on that line and examine brush.size(), hh, brushWidth, and ww to make sure you are accessing an index of brush that is in bounds.

The other thing, that whole second block of code looks suspicious, especially the part where you access map.map[ (h+hh)*map.getWidth()+w+ww ]. Are you sure you need to offset the index by hh and ww there? Won't that go out of bounds of your map?

Edit for your edit
Not sure what's going on with your saving/loading code. You could add in a check to make sure that the return value of al_fwrite32le is always 4 (bytes written).

From lookin at al_fread32le, -1 is also what it returns when it has reached the end of the file. Add in a check for al_feof to your loading code and make sure it's not hitting the end of the file prematurely.

Something else you can do is check the number of bytes in the file and compare it to (2*4 + 4*(map.Height()*map.Width())) to make sure the file is written correctly and can be read correctly.

Audric

In load: You read the width and height as fwidth and fheight, but then you loop over map.getWidth() and map.getHeight(), and write into map.map[] Between the two, I assume you should reallocate/reinit the map with these dimensions, so that getWidth() and getHeight() return the right values and the array has correct size.

Disregard that, I missed the create()

jason perkins

Yeah Edgar durring that block of code (that appears to be working, and I removed fromt he post). I'm copying the bitmaps/id's from my brush to the map. So if I click in the bottom right of my map, it will go out of bounds, but I check for it I get no issues from that.

I'm so out of Ideas at this point I'm just going to wipe this file and start from scratch thanks for taking the time to check though.

Edit: This just got a whole lot weirder. I tracked down the problem exactly And it's... strange.

Everything works fine up until I set a map id to equal exactly 26, if I try to load a file with a 26 in it it'll crash, 25 works, 27 works, 254 works... but 26 fails.

I'm just going to post the whole damn thing. There's nothing special about 26. So confused.

edit...

Well aparently it's just when I try to load a 26, The program is acting like the file ends So al_fread16be(...)When this encounters a 26 for some reason is returning as -1, and This is what's setting the rest of my map ids out of bounds

I've tried using al_fwrite/fread32le(), as well as casting the integers I'm saving to int32_t, and int16_t... nothings working.

#SelectExpand
   1
   2#include "headers.h"
   3extern int currentLayer;
   4CLayer::CLayer()
   5{
   6
created = false;
loaded = false;
selectRectStartX = 0;
selectRectStartY = 0;
selectRect = false;
menu = CMenu();
menu.setVisible(true);
brushVisible = false;
pallet.setVisible(false);
map.setVisible(false);
  17
  18
  19
  20}
  21
  22void CLayer::create(int a, int b, std::string c)
  23{
ALLEGRO_FILE* file;
file = al_fopen(c.c_str(), "r");
if(file)
{
  al_fclose(file);
  created = true;
  pallet.pallet.clear();
  pallet = CPallet(c);
  map = CMap(a, b);
  33
  map.setAllBmps(pallet.getBmp(0));
  brush.clear();
  brush.push_back(CTile(pallet.getBmp(0)));
  brush[0].setX(0);
  brush[0].setY(0);
  39
  brushWidth = 1;
  brushHeight = 1;
  brushVisible = false;
  map.setVisible(false);
  pallet.setVisible(false);
  menu.setVisible(true);
  std::cout << "Created a " << a<< "X"<< b << " Map for your amusement!\n";
}
else
{
  std::cout <<"Could Not Open " << c << " Creation Aborted!\n ";
}
  52
  53}
  54
  55void CLayer::save(std::string a)
  56{
if (created== true)
{
  ALLEGRO_FILE* file;
  60
  file = al_fopen(a.c_str(), "w");
  
  if(file)
  al_fwrite16be(file, map.getWidth());
  al_fwrite16be(file, map.getHeight());
  66
  for (int h = 0; h<map.getHeight(); h++)
  {
    for (int w = 0; w<map.getWidth(); w++)
    {
      al_fwrite16be(file, map.map[h*map.getWidth()+w].getId());
    }
  }
  74
  al_fclose(file);
  std::cout << "Saved " << a << endl;
}
  78}
  79
  80void CLayer::load(std::string a, std::string b)
  81{
ALLEGRO_FILE* file;
ALLEGRO_FILE* file2;
  84
file = al_fopen(a.c_str(), "r");
file2 = al_fopen(b.c_str(), "r");
  87
if (file && file2)
{al_fclose(file2);
  {
    int fwidth = 0;
    int fheight = 0;
  93
    fwidth = al_fread16be(file);
    fheight = al_fread16be(file);
    create(fwidth, fheight, b);
    cout << "created map with width " << fwidth << " Height " << fheight << " with pallet " << b << endl;
  98
    for (int h = 0; h<map.getHeight(); h++)
    {
      for (int w = 0; w<map.getWidth(); w++)
      {
        map.map[h*map.getWidth()+w].setId(al_fread16be(file));
        map.map[h*map.getWidth()+w].setBmp(pallet.pallet[map.map[h*map.getWidth()+w].getId()].getBmp());//HERE if map.map[h*map.getWidth()+w].getId() is 26 the program crashes, 27 works, 244 works.
      }
    }
 107
    al_fclose(file);
    std::cout << "Loaded Map:"<< a << " With Pallet :" << b << endl;
    loaded = true;
  }
}
else
  std::cout << "Could Not Load " << a << " Using " << b << endl;
 115}
 116
 117
 118void CLayer::draw()
 119{
CInputManager& im = im.getInstance();
 121
if (map.isVisible())
  map.draw();
if (menu.isVisible())
  menu.draw();
if(pallet.isVisible())
  pallet.draw();
if(brushVisible)
{
  for (int i = 0; i< brush.size(); i++)
  {
    brush[i].draw();
  }
}
if(selectRect)
{
  al_draw_rectangle(selectRectStartX, selectRectStartY, im.getMouseX(), im.getMouseY(), al_map_rgb(255, 0, 0), 4);
}
 139}
 140
 141void CLayer::getInput()
 142{
if (created == true)
{
  CInputManager& im = im.getInstance();
 146
  if (im.esc() && !im.oldEsc())
  {
    loaded = false;
    if (!menu.isVisible())
    {
      menu.setVisible(true);
      map.setVisible(false);
      brushVisible =false;
      pallet.setVisible(false);
    }
    else
    {
      menu.setVisible(false);
      map.setVisible(true);
      brushVisible = true;
    }  
  }
 164
  if (im.tab() && im.oldTab() && !menu.isVisible())
  {
    pallet.setVisible(true);
    map.setVisible(true);
    brushVisible = false;
    menu.setVisible(false);
  }
  else
  {
    pallet.setVisible(false);
  }
 176
  if (!pallet.isVisible() && !menu.isVisible())
  {
    brushVisible= true;
  }
 181
  if (pallet.isVisible())
  {
    
    if (im.rClick() && !im.oldRClick())
    {
      //start drawing a rectangle to select multiple tiles
      selectRect = true;
      selectRectStartX = im.getMouseX();
      selectRectStartY = im.getMouseY();
    }
 192
 193
    if (!im.rClick() && im.oldRClick())
    {
      //user let go of right click, they've selected the tiles they want to be coppied to brush
      //setting this rectangle so that rectx1/recty1 is the top left
      if (im.getMouseX() <= selectRectStartX)
      {
        rectX1 = im.getMouseX();
        rectX2 = selectRectStartX;
      }
        
      else
      {
        rectX1 = selectRectStartX;
        rectX2 = im.getMouseX();
      }
 209
      if (im.getMouseY() <= selectRectStartY)
      {
        rectY1 = im.getMouseY();
        rectY2 = selectRectStartY;
      }
      else
      {
        rectY1 = selectRectStartY;
        rectY2 = im.getMouseY();
      }
 220
      brush.clear();
      //clear brush and add selected tiles to it.
      for (int i = 0; i < pallet.pallet.size(); i++)
      {
        if (pallet.pallet[i].getX() + TILE_SIZE >= rectX1 && pallet.pallet[i].getX() <= rectX2 &&
          pallet.pallet[i].getY() + TILE_SIZE >= rectY1  && pallet.pallet[i].getY() <= rectY2)
        {
          brush.push_back(CTile(pallet.pallet[i].getBmp()));
          
          brush[brush.size()-1].setId(i);//HERE--- If This is 26, and I copy it to my map and save it
                          // The program crashes when I load
          brush[brush.size()-1].setX(pallet.pallet[i].getX()/TILE_SIZE);
          brush[brush.size()-1].setY(pallet.pallet[i].getY()/TILE_SIZE);
                
        }        
      }
 237
      if (brush.size() <1 )
        //if for some reason brush size == 0, fill it with something
      {
        brush.push_back(CTile(pallet.pallet[0].getBmp()));
      }
 243
      for (int i = 0; i < brush.size(); i++)
      {
        // move the brush to the top left of the screen
        if (i == 0)
        {
          moveThisFarX = brush[i].getX()/TILE_SIZE;
          moveThisFarY = brush[i].getY()/TILE_SIZE;
        }
        brush[i].setX(brush[i].getX()/TILE_SIZE - moveThisFarX);
        brush[i].setY(brush[i].getY()/TILE_SIZE - moveThisFarY);
      }
 255
      brushWidth = (brush[brush.size()-1].getX()/TILE_SIZE+1);
      brushHeight = (brush[brush.size()-1].getY()/TILE_SIZE+1);
      selectRect = false;
    }
  }
 261
  if (map.isVisible())
  {
    if (im.lClick() && ! im.tab())
    {
      //set an area of the map to equal what brush is. 
 267
      for (int h = 0; h<map.getHeight(); h++)
      {
        for (int w = 0; w<map.getWidth(); w++)
 271
        {
        
          if (map.map[h*map.getWidth()+w].getX() < im.getMouseX() && map.map[h*map.getWidth()+w].getX() + TILE_SIZE > im.getMouseX()  &&
            map.map[h*map.getWidth()+w].getY() < im.getMouseY() && map.map[h*map.getWidth()+w].getY() + TILE_SIZE > im.getMouseY() )
          {
            
            for (int hh = 0; hh<brushHeight; hh++)
            {
              for (int ww = 0; ww < brushWidth; ww++)
              {        
                if ((h+hh)*map.getWidth()+w+ww < map.getWidth()*map.getHeight())
                {
 284
                  map.map[ (h+hh)*map.getWidth()+w+ww ].setBmp(brush[hh*brushWidth+ww].getBmp());
 286
                  //if (brush[hh*brushWidth+ww].getId() != 26)//##### THIS If the Id is anything
                                        //other Than 26, saving/loading works as intended
                  map.map[ (h+hh)*map.getWidth()+w+ww ].setId(brush[hh*brushWidth+ww].getId());
                }
              }          
 292
            }
            
          }  
        }
      }
    }
 299
    if (!im.tab())
    {
      map.getInput();
    }
  }
 305
  if (pallet.isVisible())
  {
    if (im.lClick() )
    {
      //if left clicking pallet, set brush's id to equal that pallet Id
 311
      for (int h = 0; h<pallet.getHeight(); h++)
      {
        for (int w = 0; w<pallet.getWidth(); w++)
        {
          if (pallet.pallet[h*pallet.getWidth()+w].getX() < im.getMouseX() && pallet.pallet[h*pallet.getWidth()+w].getX() + TILE_SIZE >im.getMouseX() &&
          pallet.pallet[h*pallet.getWidth()+w].getY() < im.getMouseY() && pallet.pallet[h*pallet.getWidth()+w].getY() + TILE_SIZE >im.getMouseY() )
          {
            brush.clear();
            brush.push_back(CTile(pallet.pallet[h*pallet.getWidth()+w].getBmp()));
            brush[brush.size()-1].setId(h*pallet.getWidth()+w);
            brushWidth = 1;
            brushHeight = 1;
          }
 325
        }
      }
    }
    pallet.getInput();
  }
  
}
if (menu.isVisible())
{
  menu.getInput(currentLayer);
}
 337}

Edit:: problem Solved in another thread, thanks guys!!

Thread #606709. Printed from Allegro.cc